feat(worker): add glob pattern support for worker node job affinity #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
requested changes
Dec 22, 2025
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
Please, check my comments 🙂
shiyasmohd
force-pushed
the
shiyasmohd/node-id-glob
branch
from
4ae7737 to
af76224
Compare
Contributor
Author
|
@LNSD All comments has been solved now. |
LNSD
requested changes
Dec 23, 2025
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
In general, it's ok, I miss the docs.
JFYI: You can ask Claude to follow the .patterns/error-reporting.md and .patterns/documentation.md guidelines.
shiyasmohd
force-pushed
the
shiyasmohd/node-id-glob
branch
from
af76224 to
df6c756
Compare
shiyasmohd
force-pushed
the
shiyasmohd/node-id-glob
branch
from
df6c756 to
998dc72
Compare
Contributor
Author
|
@LNSD Pushed the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin-apiandampctlto accept glob patternCloses #1508