fix(extractor/solana): properly handle partially downloaded OF1 files #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
approved these changes
Dec 23, 2025
Comment on lines
220
to
260
| match num_retries { | ||
| 0 => { | ||
| // First error, make sure it is visible in info (default) logs. | ||
| num_retries += 1; | ||
| tracing::info!(block = %current_block, error = %e, "Block streaming failed, retrying"); | ||
| tokio::time::sleep(DEBUG_RETRY_DELAY).await; | ||
| } | ||
| 1..DEBUG_RETRY_LIMIT => { | ||
| num_retries += 1; | ||
| tracing::debug!(block = %current_block, error = %e, "Block streaming failed, retrying"); | ||
| tokio::time::sleep(DEBUG_RETRY_DELAY).await; | ||
| } | ||
| DEBUG_RETRY_LIMIT..WARN_RETRY_LIMIT => { | ||
| num_retries += 1; | ||
| tracing::warn!(block = %current_block, error = %e, "Block streaming failed, retrying"); | ||
| tokio::time::sleep(WARN_RETRY_DELAY).await; | ||
| } | ||
| _ => { | ||
| tracing::error!(block = %current_block, error = %e, "Block streaming failed, retrying"); | ||
| tokio::time::sleep(ERROR_RETRY_DELAY).await; | ||
| } |
Contributor
There was a problem hiding this comment.
In the logs, next to the error field, I would add the error_source = logging::error_source(&e) for more context.
| let start = std::time::Instant::now(); | ||
| let response = reqwest::get(&car_file_url).await?; | ||
| let status = response.status(); | ||
| let action = match std::fs::metadata(dest).map(|meta| meta.len()) { |
Contributor
There was a problem hiding this comment.
I would recommend using fs_err instead of std::fs. It has superior error reporting.
- If an error occurs while downloading an OF1 CAR file, the next time the extractor runs should resume the file download. This commit adds that logic.
sistemd
force-pushed
the
sistemd/solana-handle-partial-of1-downloads
branch
from
ebb2f14 to
902c3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error occurs while downloading an OF1 CAR file, the next time the extractor runs should resume the file download. This commit adds that logic.
This bug was discovered while testing Solana full sync.