Skip to content

Fix HiDPI progress icon clipping by relayouting only on image size change #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arunjose696 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Fix HiDPI progress icon clipping by relayouting only on image size change #3567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...clipse.ui.workbench/eclipseui/org/eclipse/ui/internal/progress/ProgressAnimationItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,11 +260,21 @@ private void refresh() {
toolbar.setVisible(false);
}

boolean isImageSizeChanged(Image oldImage, Image image) {
boolean changed = true;
// check if image size really changed for old and new images
if (oldImage != null && !oldImage.isDisposed() && image != null && !image.isDisposed()) {
changed = !oldImage.getBounds().equals(image.getBounds());
}
return changed;
}

private void initButton(Image im, final String tt) {
boolean isLayoutRequired = isImageSizeChanged(im, toolButton.getImage());
toolButton.setImage(im);
toolButton.setToolTipText(tt);
toolbar.setVisible(true);
toolbar.getParent().requestLayout(); // must layout
toolbar.getParent().layout(isLayoutRequired);

if (currentAccessibleListener != null) {
toolbar.getAccessible().removeAccessibleListener(currentAccessibleListener);
Expand Down
Loading