Limit autoscale mode to quarter and exact only #2771
Merged
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2025
Contributor
Test Results 147 files ±0 147 suites ±0 21m 44s ⏱️ -47s Results for commit 9e0a902. ± Comparison against base commit 407cb9a. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
ShahzaibIbrahim
force-pushed
the
master-399-p2
branch
2 times, most recently
from
4ee56bc to
e66f2c4
Compare
amartya4256
reviewed
Nov 24, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-399-p2
branch
2 times, most recently
from
edbb7e1 to
a1581ca
Compare
HeikoKlare
reviewed
Dec 3, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java
Outdated
Show resolved
Hide resolved
ShahzaibIbrahim
force-pushed
the
master-399-p2
branch
2 times, most recently
from
5f06264 to
3d00780
Compare
HeikoKlare
force-pushed
the
master-399-p2
branch
from
3d00780 to
04fea49
Compare
SWT applications will be limited to use autoscale modes quarter and exact when having monitor-specific scaling enabled. With other, unsupported values the application will not start. To enforce application start with an incompatible autoscale mode, a new "force" value for the swt.autoScale.updateOnRuntime property is introduced. Also the tests testing other autoscale values have been removed.
HeikoKlare
force-pushed
the
master-399-p2
branch
from
04fea49 to
9e0a902
Compare
HeikoKlare
approved these changes
Dec 5, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
This looks fine now. The change also implicitly fices a wrong handling of a default swt.autoScale value when using monitor-specific scaling (see eclipse-platform/eclipse.platform.ui#3475 (comment)). Thus proposing to merge this before eclipse-platform/eclipse.platform.ui#3475 to fix the adopted method first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swt applications will be limited to use autoscale modes quarter and exact only otherwise user will see an error message stating the incompatibility. Also the tests testing other autoscale values have been removed.
This PR will further affect: eclipse-platform/eclipse.platform.ui#3475