Skip to content

Draft: Minor fixes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
klausschuch wants to merge 39 commits into
base: performance_improvements
Choose a base branch
from
Open

Draft: Minor fixes #27

klausschuch wants to merge 39 commits into from

Conversation

@klausschuch
Copy link
Contributor

@klausschuch klausschuch commented Mar 5, 2025

No description provided.

klausschuch and others added 30 commits March 5, 2025 19:39
@klausschuch
Encode result file names
fafeaac
@klausschuch
Keep old result file names
eb96f11
@klausschuch
Use correct separator for PPD file writer
f7276b2
@klausschuch
Display correct tree in onlinemonitoring for parameters
461a524
@Vaan5 @klausschuch
Read units of naming convention arrays as well
b3b4ace
@Vaan5 @klausschuch
Remove unused function
810f123
@klausschuch
Remove not implemented micro store level
6e738a7
@klausschuch
Prepare for event mode
bdf710c
@klausschuch
StepType: Remove unnecessary GetTime() call
48e71ac
@klausschuch
StepType: Set brackets for stepEndTime comparison correctly
0caa912
@Vaan5 @klausschuch
Use DiscreteFilter for clocked connections
f0c3908
@klausschuch
cmake: Use python detected by cmake
643c0f5
@Vaan5 @klausschuch
Fix condition (consider channel types)
5080d9e
@klausschuch
Change const type qualifier of argument of 'mcx_resolve_env_var'
7ac586a
@Vaan5 @klausschuch
Do not replace env vars if not defined
d939a0d
@Vaan5 @klausschuch
Deprecate %ENV_VAR% constructs
fa93651
@Vaan5 @klausschuch
Initialize all local variables
e2021e1
@Vaan5 @klausschuch
Function to strip the extension in a path
130aca8
@klausschuch
Add flag 'isShadowComponent'
15e4d1c
@klausschuch
Add getter and setter for 'isShadowComponent'
0fa5ae2
@klausschuch
Add channels to observable channels if they are not channels from sha…
924fb49 
…dowed components
@klausschuch
fmu2: Fix array parameter dimensionality
82ae1eb
@Vaan5 @klausschuch
Support long path when loading dlls in mcx
9ef91ff
@klausschuch
util: Add mcx_string_decode for uri decoding
d79b581
@klausschuch
util: Use windows native uri-to-path function
f8b6673
@klausschuch
Add ConnectionStatus.h/.c for storing connection status of inports
bc91d8a
@klausschuch
Add member connectionStatus to ChannelInfo
156cd4d
@klausschuch
Check if inport is already connected
f0b0215
@klausschuch
fmu: Add more signal handler guards
c96537a
@klausschuch
model: Destroy components in reverse creation order
82575cc
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 5, 2025
View reviewed changes
src/objects/ObjectContainer.c
filtered->PushBack(filtered, obj);
}
}

Check failure

Code scanning / CodeQL

Wrong type of arguments to formatting function High

This format specifier for type 'unsigned int' does not match the argument type 'unsigned long'.

Copilot Autofix

AI 10 months ago

To fix the problem, we need to update the format specifier in the mcx_log call to use %zu for size_t arguments. This ensures that the format specifier matches the type of the argument across all platforms.

  • Change the format specifier from %u to %zu for the pos and container->size arguments in the mcx_log call on line 479.
  • This change should be made in the file src/objects/ObjectContainer.c.
Suggested changeset 1
src/objects/ObjectContainer.c

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/objects/ObjectContainer.c b/src/objects/ObjectContainer.c
--- a/src/objects/ObjectContainer.c
+++ b/src/objects/ObjectContainer.c
@@ -478,3 +478,3 @@
     if (pos >= container->size) {
-        mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %u out of bounds, max is %u", pos, container->size);
+        mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %zu out of bounds, max is %zu", pos, container->size);
         return RETURN_ERROR;
EOF
@@ -478,3 +478,3 @@
if (pos >= container->size) {
mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %u out of bounds, max is %u", pos, container->size);
mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %zu out of bounds, max is %zu", pos, container->size);
return RETURN_ERROR;
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
src/objects/ObjectContainer.c
filtered->PushBack(filtered, obj);
}
}

Check failure

Code scanning / CodeQL

Wrong type of arguments to formatting function High

This format specifier for type 'unsigned int' does not match the argument type 'unsigned long'.

Copilot Autofix

AI 10 months ago

To fix the problem, we need to update the format specifier in the mcx_log function call on line 479 to match the type of the container->size argument. Specifically, we should change %u to %lu to correctly handle the size_t type, which is typically defined as unsigned long.

  • Update the format specifier in the mcx_log function call on line 479 from %u to %lu.
  • Ensure that the change is made only in the relevant line to avoid altering existing functionality.
Suggested changeset 1
src/objects/ObjectContainer.c

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/objects/ObjectContainer.c b/src/objects/ObjectContainer.c
--- a/src/objects/ObjectContainer.c
+++ b/src/objects/ObjectContainer.c
@@ -478,3 +478,3 @@
     if (pos >= container->size) {
-        mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %u out of bounds, max is %u", pos, container->size);
+        mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %lu out of bounds, max is %lu", pos, container->size);
         return RETURN_ERROR;
EOF
@@ -478,3 +478,3 @@
if (pos >= container->size) {
mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %u out of bounds, max is %u", pos, container->size);
mcx_log(LOG_ERROR, "ObjectContainer: SetElementName: Position %lu out of bounds, max is %lu", pos, container->size);
return RETURN_ERROR;
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@klausschuch klausschuch changed the base branch from main to performance_improvements March 5, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klausschuch @Vaan5