Fixes for Brexit #96
Open
Fixes for Brexit #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial try at changes to query to account for trials that were ongoing as of the date of Brexit and are now in status: 'GB - no longer in EU/EEA' To account for this we: 1. Created a new trial status variable called `gb_exclude` 2. Fixed the categorical variable for trial status so that now if a trial is completed in all locations other than `GB - no longer in EU/EEA` it is considered completed and added a category for trials that are only in trial status `GB - no longer in EU/EEA` 3. This is now accounted for when we check for `results_expected`. A trial that is only in status `GB - no longer in EU/EEA` will no longer become due ever. A trial with `GB - no longer in EU/EEA` and all other completed/terminated trials will become due by the normal procedure. 4. Added a new binary variable to the final dataset called `brexit_excluded` that is for trails that are only in the `GB - no longer in EU/EEA` status.
Contributor
Author
|
Failing tests because Edit: Attempted to address this through the below commit. Edit: aaaaand it didn't work... |
Contributor
Author
|
Have only changed Ideally I'd like to just replace everything with some python I've created in the long run. |
Adding new column `brexit_excluded` so the tests can potentially pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial try at changes to query to account for trials that were ongoing as of the date of Brexit and are now in status: 'GB - no longer in EU/EEA'
To account for this we:
gb_excludeGB - no longer in EU/EEAit is considered completed and added a category for trials that are only in trial statusGB - no longer in EU/EEAresults_expected. A trial that is only in statusGB - no longer in EU/EEAwill no longer become due ever. A trial withGB - no longer in EU/EEAand all other completed/terminated trials will become due by the normal procedure.brexit_excludedthat is for trails that are only in theGB - no longer in EU/EEAstatus.