Skip to content

Conversation

@ebigunso
Copy link
Owner

Summary:

  • Normalize Docker entrypoint by stripping CRLF at build and ensuring it is executable to prevent "exec … no such file or directory".
  • Split env files: add .env.docker.example; docker compose uses env_file; ignore .env.docker.
  • Add .dockerignore to reduce build context size.
  • Document COOKIE_SECURE=0 in .env.example for local HTTP dev.
  • README updates.

Diffstat vs main:
.dockerignore | 19 +++++++++++++++++++
.env.docker.example | 30 ++++++++++++++++++++++++++++++
.env.example | 5 +++++
.gitignore | 3 +++
Dockerfile | 5 ++++-
README.md | 42 +++++++++++++++++++++++++++++++++++++++++-
compose.yaml | 4 ++--
7 files changed, 104 insertions(+), 4 deletions(-)

Commits since main:

  • 1c1bce3 :note: Readme update
  • 568fb2d fix(docker): strip CRLF from entrypoint in image build to prevent "exec … no such file or directory" and ensure script is executable
  • ac81cfc 📝 Additional notes to Readme
  • cbe9d93 docs: document COOKIE_SECURE=0 in .env.example for local HTTP dev
  • 8011097 Use separate env files: add .env.docker.example; compose uses env_file; add .dockerignore; update README; ignore .env.docker

Comparison: main...feature/2025-08-12/fix-docker-auth

Copilot AI review requested due to automatic review settings August 13, 2025 18:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Docker deployment issues and improves the development experience by normalizing the Docker entrypoint, separating environment configurations, and reducing build context size.

Key changes:

  • Fixed Docker entrypoint execution issues by stripping CRLF line endings and ensuring proper permissions
  • Separated environment configurations with dedicated .env.docker.example file for Docker deployments
  • Added .dockerignore to optimize build performance by excluding unnecessary files

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
compose.yaml Updated to use env_file instead of hardcoded environment variables
README.md Added comprehensive Docker setup instructions and environment configuration guidance
Dockerfile Fixed entrypoint script by normalizing line endings and setting execute permissions
.env.example Added COOKIE_SECURE=0 documentation for local HTTP development
.env.docker.example New Docker-specific environment template with secure defaults
.dockerignore New file to exclude build artifacts and sensitive files from Docker context

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ebigunso ebigunso self-assigned this Aug 13, 2025
@ebigunso ebigunso changed the title fix(docker): normalize entrypoint; add .env.docker.example and .dockerignore; update README and compose 🐛 Fixed Docker setup to run as expected Aug 13, 2025
@ebigunso ebigunso merged commit 8e004f0 into main Aug 13, 2025
2 checks passed
@ebigunso ebigunso deleted the feature/2025-08-12/fix-docker-auth branch August 13, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants