[19942] Make remove unused entities compatible with the discovery trigger #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 16 16
Lines 559 559
Branches 297 297
=======================================
Hits 170 170
Misses 202 202
Partials 187 187 ☔ View full report in Codecov by Sentry. |
tempate
force-pushed
the
feature/dynamic_tracks_discovery_trigger
branch
from
f1c8163 to
bddc665
Compare
juanlofer-eprosima
requested changes
Jul 15, 2024
Contributor
juanlofer-eprosima
left a comment
juanlofer-eprosima
left a comment
There was a problem hiding this comment.
I miss tests for the new scenario.
| .. warning:: | ||
| At the time being, the removal of unused entities is incompatible with the `Transient-Local Durability QoS <https://fast-dds.docs.eprosima.com/en/latest/fastdds/dds_layer/core/policy/standardQosPolicies.html#durabilityqospolicy>`_. | ||
|
|
||
| .. warning:: |
Contributor
There was a problem hiding this comment.
Update release notes.
|
|
||
| .. warning:: | ||
| At the time being, :ref:`remove-unused-entities <user_manual_configuration_remove_unused_entities>` set to ``true`` is only compatible with a ``discovery-trigger: reader``. | ||
| When the |ddsrouter| creates internal entities triggered by the discovery of a writer (i.e. the `` `` is either ``writer`` or ``any``), the |ddsrouter| will create its internal entities with the writer's :ref:`Topic QoS <user_manual_configuration_topic_qos>`, and, therefore, the QoS of the communication between the external entities and the |ddsrouter| may differ from the QoS of the communication without the |ddsrouter|. |
tempate
force-pushed
the
feature/dynamic_tracks_discovery_trigger
branch
from
bddc665 to
a1db606
Compare
added 2 commits
September 18, 2024 12:18
Signed-off-by: tempate <danieldiaz@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/dynamic_tracks_discovery_trigger
branch
from
a1db606 to
b209bc5
Compare
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after: