fix(EbayLightboxDialog): observe child nodes changes to refresh keyboard trap #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an observer on the dialog element that checks for nodes removal/addition and refresh the keyboard trap so it make sure the first and last focusable element are always up to date. This issue is visible when data fetching is executed inside the child component and the dialog component doesn't re-render.
Notes
The same issue is possible to happen in Marko, although data fetching on component level might not be common. @agliga let me know if you want me to implement the same on marko
Screenshots
Checklist