feat: react attendance pages #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakehobbs
changed the title
jakehobbs
changed the title
jakehobbs
changed the title
jakehobbs
force-pushed
the
jake/react-attendance-2
branch
from
0368920 to
f4244e9
Compare
jakehobbs
commented
Jan 3, 2026
jakehobbs
force-pushed
the
jake/react-attendance-2
branch
from
c877be0 to
256d8d3
Compare
alexsapps
reviewed
Jan 7, 2026
alexsapps
approved these changes
Jan 11, 2026
| } | ||
|
|
||
| getActivist(name: string): { | ||
| exists: boolean |
Collaborator
There was a problem hiding this comment.
returning null would be more idiomatic, and prevent accidental usage of other fields under the false assumption that the activist must exist if the fields are accessible, and would simplify this implementation (no need optional chaining operator).
| } | ||
| } | ||
|
|
||
| function nameFilter(text: string, input: string): boolean { |
Collaborator
There was a problem hiding this comment.
can you add a doc comment for this function? not obvious what it does after staring at it for a little bit
Collaborator
There was a problem hiding this comment.
should this file be moved to event/new/page.tsx, to make room for a future event/page.tsx that lists all the events?
and should /event be renamed to /events for consistency with /users? cursory google search says plural is preferred
sorry just noticed this now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.