-
Notifications
You must be signed in to change notification settings - Fork 32
Setting appRoot by combining project root and outDir #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…thout taking into consideration baseUrl
|
Thanks for making the pr, that's exactly what I have been doing in my local version for quite some time now. Really hope this gets merged into master soon. |
|
This have been an issue for many of you :) I have to admit I have been a bit slow/lazy since this was originally crafted for my own local project structure :) I will make sure this feature will be included in the next release, which is real soon, there are a number of other features that need to be committed as well! Thanks guys for your contributions! |
duffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version is using yargs for command line parsing and the params are now static (as your table) if we´re going to show help "screen" like this we should define the params in a collection which is then iterated for the help screen to avoid having to update the static text every time a param changes.
duffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´m sorry that I overlooked your suggestion here, this feature was actually implemented a while back in my dev branch, in other words, the actual feature suggestion was good :)
However, this is a very dirty piece of code, using a static reference since the engine have no knowledge of the tspath class which is where a command param should be parsed, if you study the code everything the engine works with is properties set from the creating class so it totally breaks the pattern I have used.
Also, by using strings like this quoting a param in this case would make it harder to maintain, let´s say a parameter change or is removed, then you not only have a bug, it´s harder to spot, if you ever do a hack like this, at least use constants.
|
A fix for the problem regarding the rel dist folder is available in v 1.3.5, |
The
appRootvalue is now based on the project root path and the value set in outDir, without taking into consideration the value in baseUrl.In this way tspath calculates the dir to parse as the tsc transpiler does.