Feature/types support #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 10, 2018 10:31
…k for types in L* types in the function setBit
…Message8583 into feature/types_support # Conflicts: # ISO8583/ISO8583.py
The function that validates type would not work with the bitmap as a byte sequence rather than a string, so encoding for ascii is needed. The bit 35 was changed from n to ans, since the track 2 data contains special characters.
The bits of type LL, LLL and LLLLLL needed validation on their sizes according to the size value given by the first digits
Fix error when concatenating data types.
The bit 126 had an invalid size, 6 instead of 999. Also added some formatting to ValueTooLarge raising, and updated setup.py to include ebcdic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I added a new type (A_or_N), corrected some typos, the bit 126 specification, and some other minor changes.
I would like to request an updated on the PyPI package, to reflect the newest changes. When you install it via pip install ISO8583, the version installed is one behind the current one in the repo.
Regards.