Fix pixel definition for free-trial-conversion wide event

[nalcalag]

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212540712304974?focus=true

Description

Fix pixel definition for free trial conversion wide event pixels

Steps to test this PR

N/A

No UI changes

---

Note

Updates the wide_free-trial-conversion pixel to fix a plan ID, add sandbox plan enums, and rename activation step keys.

• Pixels
  • PixelDefinitions/pixels/wide_free_trial_conversion.json5
    • Fix plan ID in feature.data.ext.free_trial_plan enum: ddg.privacy.pro.monthly.renews.us -> ddg-privacy.pro.monthly.renews.us.
    • Add sandbox plan IDs to feature.data.ext.free_trial_plan enum.
    • Rename activation step keys: feature.data.ext.step.vpn_activated_d1.success -> feature.data.ext.step.vpn_activated_d1, and feature.data.ext.step.vpn_activated_d2_to_d7.success -> feature.data.ext.step.vpn_activated_d2_to_d7.

^{Written by Cursor Bugbot for commit b4bbf94. This will update automatically on new commits. Configure here.}

[nalcalag]

• Fix pixel definition for free-trial-conversion wide event #7426 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Privacy Review task: https://app.asana.com/0/69071770703008/1212559196349116

[cursor]

Inconsistent plan ID prefix between monthly and yearly plans

The plan ID naming shows an inconsistency after this change. Only US monthly plans use the ddg-privacy prefix (with hyphen), while US yearly plans still use ddg.privacy (with dot). Specifically, ddg-privacy.pro.monthly.renews.us and ddg-privacy.pro.sandbox.monthly.renews.us use hyphen, but ddg.privacy.pro.yearly.renews.us and ddg.privacy.pro.sandbox.yearly.renews.us use dot. If the fix to use hyphen is correct for monthly plans, the yearly US plans may need the same update.

 

[lmac012]

@nalcalag shouldn't all of these use hyphens instead of dots as separators? I assume values should match what we have in SubscriptionConstants.kt:

    // List of plans
    const val YEARLY_PLAN_US = "ddg-privacy-pro-yearly-renews-us"
    const val MONTHLY_PLAN_US = "ddg-privacy-pro-monthly-renews-us"
    const val YEARLY_PLAN_ROW = "ddg-privacy-pro-yearly-renews-row"
    const val MONTHLY_PLAN_ROW = "ddg-privacy-pro-monthly-renews-row"

[lmac012]

LGTM, just one comment regarding the use of dots instead of hyphens in plan ids.

[lmac012]

@nalcalag shouldn't all of these use hyphens instead of dots as separators? I assume values should match what we have in SubscriptionConstants.kt:

    // List of plans
    const val YEARLY_PLAN_US = "ddg-privacy-pro-yearly-renews-us"
    const val MONTHLY_PLAN_US = "ddg-privacy-pro-monthly-renews-us"
    const val YEARLY_PLAN_ROW = "ddg-privacy-pro-yearly-renews-row"
    const val MONTHLY_PLAN_ROW = "ddg-privacy-pro-monthly-renews-row"