Skip to content

Conversation

@nicornk
Copy link

@nicornk nicornk commented Dec 3, 2025

Wasn't able to run the tests locally, as pytest fails for me with an error related to cmake not found, even though it's present.

implementation copies the row_group_size_bytes approach.

@matthewbayer
Copy link

this kwarg would also be very useful!

@nicornk
Copy link
Author

nicornk commented Dec 5, 2025

@evertlammerts would you be able to pull this in?

@evertlammerts
Copy link
Collaborator

evertlammerts commented Dec 5, 2025

@evertlammerts would you be able to pull this in?

@nicornk it'd be good if you can run tests either locally or in your personal GH first (preferably both :)). I see that the tests didn't run in your CI because your fork doesn't have the tags. If you've set the correct upstream then you should be able to get them with git fetch --all. See more on how to set up your dev env here: https://duckdb.org/docs/stable/dev/building/python Running tests for duckdb prs is good practice in general because we're low on CI runners most of the time, but around releases (such as now) it's especially important to use CI only when you've a good idea that tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants