Skip to content

Update datetime module as datetime.datetime.utcfromtimestamp() is deprecated #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlenski merged 1 commit into from
Jan 28, 2025
Merged

Update datetime module as datetime.datetime.utcfromtimestamp() is deprecated #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fitparse/processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ def process_type_bool(self, field_data):
def process_type_date_time(self, field_data):
value = field_data.value
if value is not None and value >= 0x10000000:
field_data.value = datetime.datetime.utcfromtimestamp(UTC_REFERENCE + value)
field_data.value = datetime.datetime.fromtimestamp(timestamp=(UTC_REFERENCE + value), tz=datetime.timezone.utc).replace(tzinfo=None)
field_data.units = None # Units were 's', set to None

def process_type_local_date_time(self, field_data):
if field_data.value is not None:
# NOTE: This value was created on the device using it's local timezone.
# Unless we know that timezone, this value won't be correct. However, if we
# assume UTC, at least it'll be consistent.
field_data.value = datetime.datetime.utcfromtimestamp(UTC_REFERENCE + field_data.value)
field_data.value = datetime.datetime.fromtimestamp(timestamp=(UTC_REFERENCE + field_data.value), tz=datetime.timezone.utc).replace(tzinfo=None)
field_data.units = None

def process_type_localtime_into_day(self, field_data):
Expand Down
2 changes: 1 addition & 1 deletion tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def generate_fitfile(data=None, endian='<'):


def secs_to_dt(secs):
return datetime.datetime.utcfromtimestamp(secs + UTC_REFERENCE)
return datetime.datetime.fromtimestamp(timestamp=(secs + UTC_REFERENCE), tz=datetime.timezone.utc).replace(tzinfo=None)


def testfile(filename):
Expand Down
Loading