[Dev environments] Support windsurf IDE #3444
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| version = values.get("version") | ||
| if ide == "windsurf" and version: | ||
| # Validate format: version@commit | ||
| if not re.match(r"^.+@[a-f0-9]+$", version): |
There was a problem hiding this comment.
Regex allows multiple @ but split assumes exactly one
The regex validation ^.+@[a-f0-9]+$ allows versions containing multiple @ symbols (e.g., 1.0@@abc123 or 1.0@beta@abc123) because .+ is greedy and matches characters including @. However, windsurf.py uses version, commit = self.version.split("@") which expects exactly two parts. A malformed version passing validation would cause a runtime ValueError: too many values to unpack. The regex could use ^[^@]+@[a-f0-9]+$ to explicitly exclude @ from the version portion.
Additional Locations (1)
jvstme
left a comment
jvstme
left a comment
There was a problem hiding this comment.
The Python part LGTM. Left some comments regarding Windsurf version detection that may be worth addressing before merge
| console.print( | ||
| "[secondary]Unable to detect the Windsurf version and pre-install extensions. " | ||
| "Fix by opening [code]Command Palette[/code], executing [code]Shell Command: " | ||
| "Install 'surf' command in PATH[/code], and restarting terminal.[/]\n" | ||
| ) |
There was a problem hiding this comment.
Can't find it in the Command Palette. Am I doing something wrong?
Also can't find it in VSCode
There was a problem hiding this comment.
Windsurf Version: 1.13.5
Same in VSCode (Version: 1.106.3):
Replaced `surf` with `windsurf`(which is the only one alaviable on Linux)
Fixes #3443
Note
Adds Windsurf as a first-class IDE option for dev environments across UI, types, CLI, and server.
windsurfinIDE_OPTIONS, updates types and "Connect" flow to use dynamic IDE labels/URLsTIdeand form value typings to includewindsurfwindsurftoDevEnvironmentConfigurationParams; validate Windsurfversionasversion@commitWindsurfDesktopinstaller/README commands and wiring in dev job configuratorWritten by Cursor Bugbot for commit 9e51925. This will update automatically on new commits. Configure here.