Fix wrong icon sizes on GNOME 49 #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure all icons have `viewBox="0 0 16 16"`. - Resize icons if necessary. - Remove editor metadata (e.g. Inkscape). - Drop fixed `width` and `height`. Fixes dsheeler#280
marmitar
force-pushed
the
fix/svg-icons
branch
from
fd1ea62 to
b4f2013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Hi, this PR adds a
svgo.config.mjsthat:viewBox="0 0 16 16"(GNOME works with multiples of 16, see GNOME Guidelines).widthandheightattributes.Then you just run it with
npx svgo ui/icons/hicolor/scalable/actions/*.svg(one or more times) and you should get the new SVG files included here.Screenshots
At 1080p, 100%, Light Theme.
I don't have a HiDPI screen to test, but I think this should be close: 1080p, 200%, Dark Theme.
With
scale-monitor-framebuffer: 1080p, 133%, Dark Theme.