Skip to content

Please consider the following formatting changes to #12314 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsekihat merged 1 commit into from
Jul 29, 2025
Merged

Please consider the following formatting changes to #12314 #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions PWGEM/Dilepton/Tasks/smearing.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,21 @@
// Analysis task to produce smeared pt, eta, phi for electrons/muons in dilepton analysis
// Please write to: daiki.sekihata@cern.ch

#include <array>
#include <string>
#include <chrono>
#include "PWGEM/Dilepton/DataModel/dileptonTables.h"
#include "PWGEM/Dilepton/Utils/MomentumSmearer.h"

#include "CCDB/BasicCCDBManager.h"
#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/ASoAHelpers.h"
#include "Framework/ASoA.h"
#include "Framework/ASoAHelpers.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/DataTypes.h"
#include "Framework/HistogramRegistry.h"
#include "PWGEM/Dilepton/Utils/MomentumSmearer.h"
#include "PWGEM/Dilepton/DataModel/dileptonTables.h"
#include "Framework/runDataProcessing.h"

#include <array>
#include <chrono>
#include <string>

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -193,7 +194,7 @@
template <o2::aod::pwgem::dilepton::smearing::EMAnaType type, typename TTracksMC, typename TCollisions, typename TMCCollisions>
void applySmearing(TTracksMC const& tracksMC, TCollisions const& collisions, TMCCollisions const&)
{
for (auto& mctrack : tracksMC) {

Check failure on line 197 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
float ptgen = mctrack.pt();
float etagen = mctrack.eta();
float phigen = mctrack.phi();
Expand All @@ -217,7 +218,7 @@
}

int pdgCode = mctrack.pdgCode();
if (std::abs(pdgCode) == 11) {

Check failure on line 221 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
int ch = -1;
if (pdgCode < 0) {
ch = 1;
Expand All @@ -231,7 +232,7 @@
// fill the table
smearedelectron(ptsmeared, etasmeared, phismeared, efficiency, dca);
smearedmuon(ptgen, etagen, phigen, 1.f, 0.f, ptgen, etagen, phigen, 1.f, 0.f);
} else if (std::abs(pdgCode) == 13) {

Check failure on line 235 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
int ch = -1;
if (pdgCode < 0) {
ch = 1;
Expand Down Expand Up @@ -275,12 +276,12 @@
void processDummyCocktail(aod::McParticles const& tracksMC)
{
// don't apply smearing
for (auto& mctrack : tracksMC) {

Check failure on line 279 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
int pdgCode = mctrack.pdgCode();
if (std::abs(pdgCode) == 11) {

Check failure on line 281 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
smearedelectron(mctrack.pt(), mctrack.eta(), mctrack.phi(), 1.0, 0.0);
smearedmuon(mctrack.pt(), mctrack.eta(), mctrack.phi(), 1.0, 0.0, mctrack.pt(), mctrack.eta(), mctrack.phi(), 1.0, 0.0);
} else if (std::abs(pdgCode) == 13) {

Check failure on line 284 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
smearedelectron(mctrack.pt(), mctrack.eta(), mctrack.phi(), 1.0, 0.0);
smearedmuon(mctrack.pt(), mctrack.eta(), mctrack.phi(), 1.0, 0.0, mctrack.pt(), mctrack.eta(), mctrack.phi(), 1.0, 0.0);
} else {
Expand All @@ -299,7 +300,7 @@
};

struct CheckSmearing {
using EMMCParticlesWithSmearing = soa::Join<aod::EMMCParticles, aod::SmearedElectrons, aod::SmearedMuons>;
using EMMCParticlesWithSmearing = soa::Join<aod::EMMCParticles, aod::SmearedElectrons, aod::SmearedMuons>;
using MyCocktailTracks = soa::Join<aod::McParticles, aod::SmearedElectrons, aod::SmearedMuons>;

// Run for electrons or muons
Expand All @@ -319,7 +320,7 @@
{
registry.add<TH2>("Electron/hCorrelation_Pt", "pT correlation;p_{T,l}^{gen} (GeV/c);p_{T,l}^{smeared} (GeV/c)", {HistType::kTH2F, {{1000, 0.0f, 10.0f}, {1000, 0.0f, 10.0f}}});
registry.add<TH2>("Electron/hCorrelation_Eta", "eta correlation;#eta_{l}^{gen};#eta_{l}^{smeared}", {HistType::kTH2F, {{200, -1.0f, +1.0f}, {200, -1.0f, +1.0f}}});
registry.add<TH2>("Electron/hCorrelation_Phi", "phi correlation;#varphi_{l}^{gen} (rad.);#varphi_{l}^{smeared} (rad.)", {HistType::kTH2F, {{100, 0.0f, TMath::TwoPi()}, {100, 0.0f, TMath::TwoPi()}}});

Check failure on line 323 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[external-pi] 

Use the PI constant (and its multiples and fractions) defined in o2::constants::math.

// Binning for resolution
AxisSpec axisPtRes{ptResBins, "#it{p}^{gen}_{T,l} (GeV/#it{c})"};
Expand All @@ -341,13 +342,12 @@

registry.addClone("Electron/", "GlobalMuon/");
registry.addClone("Electron/", "StandaloneMuon/");

}

template <o2::aod::pwgem::dilepton::smearing::EMAnaType type, typename TTracksMC, typename TMCCollisions>
void Check(TTracksMC const& tracksMC, TMCCollisions const&)
{
for (auto& mctrack : tracksMC) {

Check failure on line 350 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (std::abs(mctrack.pdgCode()) != fPdgCode) {
continue;
}
Expand All @@ -359,9 +359,9 @@
}
}

if (std::abs(mctrack.pdgCode()) == 11) { // for electrons

Check failure on line 362 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
float deltaptoverpt = -1000.f;
if (mctrack.pt() > 0.f){
if (mctrack.pt() > 0.f) {
deltaptoverpt = (mctrack.pt() - mctrack.ptSmeared()) / mctrack.pt();
}
float deltaeta = mctrack.eta() - mctrack.etaSmeared();
Expand All @@ -376,10 +376,10 @@
registry.fill(HIST("Electron/hCorrelation_Pt"), mctrack.pt(), mctrack.ptSmeared());
registry.fill(HIST("Electron/hCorrelation_Eta"), mctrack.eta(), mctrack.etaSmeared());
registry.fill(HIST("Electron/hCorrelation_Phi"), mctrack.phi(), mctrack.phiSmeared());
} else if (std::abs(mctrack.pdgCode()) == 13) { // for muons

Check failure on line 379 in PWGEM/Dilepton/Tasks/smearing.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
float deltaptoverpt = -1000.f;
// for standalone muons
if (mctrack.pt() > 0.f){
if (mctrack.pt() > 0.f) {
deltaptoverpt = (mctrack.pt() - mctrack.ptSmeared_sa_muon()) / mctrack.pt();
}
float deltaeta = mctrack.eta() - mctrack.etaSmeared_sa_muon();
Expand All @@ -396,7 +396,7 @@
registry.fill(HIST("StandaloneMuon/hCorrelation_Phi"), mctrack.phi(), mctrack.phiSmeared_sa_muon());

// for global muons
if (mctrack.pt() > 0.f){
if (mctrack.pt() > 0.f) {
deltaptoverpt = (mctrack.pt() - mctrack.ptSmeared_gl_muon()) / mctrack.pt();
}
deltaeta = mctrack.eta() - mctrack.etaSmeared_gl_muon();
Expand Down
Loading