Add integration test for ignore_multi_database_name config option #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem: The ignore_multi_database_name option can be set via configuration file, but there was no integration test to ensure it works correctly in a multi-database environment. ## Solution: Add an integration test in annotate_models_in_multi_db_spec.rb that: - Creates a config file with ignore_multi_database_name: true - Verifies that database names are not included in annotations for both primary and secondary database models
drwl
approved these changes
Jan 2, 2026
Owner
drwl
left a comment
drwl
left a comment
There was a problem hiding this comment.
Thanks for increasing test coverage!
OdenTakashi
deleted the
test/add-integration-test-for-ignore-multi-database-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The ignore_multi_database_name option can be set via configuration file, but there was no integration test to ensure it works correctly in a multi-database environment.
Solution:
Add an integration test in annotate_models_in_multi_db_spec.rb that: