Skip to content

Conversation

@maraf
Copy link
Member

@maraf maraf commented May 14, 2024

  • Add WBT test checking that downlevel versions we compute are lower than versions in "latest" SDK

TODO

  • New validation logic
    • If we compute lower version than in SDK => Fail
    • If we compute the same version => OK
    • If we compute +1 than what's in SDK => do it in WBT build and disable tests for downlevel as this is expected directly after servicing release
    • If we comput +2 or more => Fail

Fixes #101809

@maraf maraf added arch-wasm WebAssembly architecture area-Workloads Workloads like wasm-tools labels May 14, 2024
@maraf maraf added this to the 9.0.0 milestone May 14, 2024
@maraf maraf requested a review from lewing May 14, 2024 12:32
@maraf maraf self-assigned this May 14, 2024
@maraf maraf requested a review from ilonatommy as a code owner May 14, 2024 12:32
@maraf maraf requested a review from akoeplinger May 14, 2024 14:16
@lewing
Copy link
Member

lewing commented May 14, 2024

CI is timing out a lot right now, will restart once things have settled down

@maraf

This comment was marked as resolved.

@lewing lewing modified the milestones: 9.0.0, 10.0.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-Workloads Workloads like wasm-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[workloads] add wbt that checks downlevel runtime versions.

3 participants