Fix for transition precedence no longer given to substates #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itions when they override a parent state's transitions.
RedOrc
reviewed
Aug 21, 2025
|
|
||
| namespace Stateless.Tests | ||
| { | ||
| public class TransitionFixture |
Contributor
There was a problem hiding this comment.
Very minor @mclift, but can we be explicit about the class name? I think changing this from TransitionFixture to TransitionFixtureTest is better. Thoughts?
Member
Author
There was a problem hiding this comment.
I think I'm right in saying that the "Fixture" nomenclature was simply in common use when this library was first written and that just "Tests" would be more idiomatic now. Given there's a mixture of both in the project, perhaps renaming them all would be the right thing to do?
Contributor
Member
Author
There was a problem hiding this comment.
@RedOrc Sounds good. I've done this one in the meantime.
RedOrc
approved these changes
Aug 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #624, in which a breaking change in v5.18.0 caused asynchronous substate transitions to be ignored when a viable parent state transition is configured. These changes are intended to restore the transition precedence from prior releases.
Fixed the trigger handler selection logic in
StateRepresentation.Async.csso that substate (local) transitions are preferred over superstate transitions in async scenarios. This ensures correct transition precedence when both substate and superstate can handle the same trigger.Added new tests in
TransitionFixture.csto verify that substate transitions correctly override superstate transitions for both synchronous and asynchronous trigger firing.Improved test naming and clarity in
TransitionFixture.csfor reentry and transition tests, making the intent of each test clearer.