Skip to content

fix: correct URLEncoder detection in UrlEncoderUtils #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dora4 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct URLEncoder detection in UrlEncoderUtils #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dcache/src/main/java/dora/http/log/UrlEncoderUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ class UrlEncoderUtils private constructor() {
if (isValidHexChar(c1) && isValidHexChar(c2)) {
encode = true
break
} else {
break
}
}
}
Expand Down
19 changes: 19 additions & 0 deletions dcache/src/test/java/dora/http/log/UrlEncoderUtilsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package dora.http.log

import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.junit.Test

class UrlEncoderUtilsTest {

@Test
fun hasUrlEncoded_detectsValidSequences() {
assertTrue(UrlEncoderUtils.hasUrlEncoded("abc%20def"))
}

@Test
fun hasUrlEncoded_ignoresInvalidSequences() {
assertTrue(UrlEncoderUtils.hasUrlEncoded("abc%2G%20def"))
assertFalse(UrlEncoderUtils.hasUrlEncoded("abc%2Gdef"))
}
}