Skip to content

Conversation

@davidstanke
Copy link
Collaborator

@davidstanke davidstanke commented Dec 22, 2025

This PR fixes an issue with duplicate type fields in two Hugo files, which caused build failures in newer versions of Hugo.

Preview: https://doradotdev--pr1266-drafts-on-zhj924ad.web.app/research/2024/

(note: while working through this, I had some weirdness with Svelte builds, so you'll see some changes in the core-v2 folder, but then that cleared up and so I reverted that. Just ignore the commit history and look at the files changed. It's really rather simple.)

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains refactoring changes. It removes the type field from the front matter of two markdown files, which seems to be a move towards standardizing content types. It also updates the target element ID for a Svelte application to align with its development index.html.

I've identified one issue with the Svelte change. While the JavaScript is now correct for the development environment, the associated CSS file was not updated. This will cause styling issues, as the container for the Svelte app will lose its max-width and centering properties. I've left a specific comment with details.

On a lighter note, why did the coffee file a police report? It got mugged!

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Visit the preview URL for this PR (updated for commit 3c1d999):

https://doradotdev--pr1266-drafts-on-zhj924ad.web.app

(expires Thu, 22 Jan 2026 15:49:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7ad2b3cf9cceb558b493931176f998ae46924361

@davidstanke davidstanke marked this pull request as ready for review December 23, 2025 15:56
@nathenharvey nathenharvey merged commit 4576679 into main Dec 23, 2025
7 checks passed
@nathenharvey nathenharvey deleted the dedupe-type branch December 23, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants