Skip to content

Conversation

@loic425
Copy link
Contributor

@loic425 loic425 commented Nov 24, 2025

No description provided.

@loic425
Copy link
Contributor Author

loic425 commented Nov 25, 2025

There are issues with doctrine persistence 4...

@dbu
Copy link
Member

dbu commented Nov 25, 2025

thanks for looking into this loic!

There are issues with doctrine persistence 4...

yep, seems signatures changed. do we have to allow persistence 4 for symfony 8 support? if we do, we might need some ugly BC hack, or think if we can at the same time remove support for persistence 3 and ourselves bump a minor version.

@loic425
Copy link
Contributor Author

loic425 commented Nov 26, 2025

@dbu Indeed, Symfony 8 is only a dev requirement on doctrine persistence. So it should be ok.

@loic425 loic425 mentioned this pull request Nov 26, 2025
7 tasks
@loic425
Copy link
Contributor Author

loic425 commented Nov 26, 2025

Hum.... For now, at least doctrine-bundle 3.1.x branch supports Symfony 8 https://packagist.org/packages/doctrine/doctrine-bundle#3.1.x-dev, but this branch requires at least doctrine persistence 4.

@dbu
Copy link
Member

dbu commented Nov 29, 2025

blocked by liip/RMT#185

@dbu
Copy link
Member

dbu commented Nov 29, 2025

i added php 8.5 builds and fixed deprecations. now the only remaining thing is probably RMT

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and with RMT updated, this passes 🎉

@dbu dbu merged commit 7f27ea5 into doctrine:2.1.x Dec 3, 2025
40 of 42 checks passed
@loic425 loic425 deleted the sf8 branch December 3, 2025 19:07
@loic425
Copy link
Contributor Author

loic425 commented Dec 4, 2025

that's great, but we need to use persistence 4 to use with the Doctrine bundle.

@dbu
Copy link
Member

dbu commented Dec 4, 2025

lets see #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants