Skip to content

Conversation

@lmakarov
Copy link
Member

@lmakarov lmakarov commented Oct 13, 2025

Summary by CodeRabbit

  • Chores

    • Upgraded development container tooling for improved stability and compatibility: Node.js 22.20.0 (with updated NVM), Platform.sh CLI 5.6.0, yq 4.48.1; code-server 4.104.3, GitLens 17.6.1, PHP Xdebug 1.37.0
    • Aligned versions across all supported images
  • Documentation

    • Updated documented Node.js version to 22.20.0 LTS
  • Tests

    • Updated test checks to POSIX-style status checks and relaxed output matching for more tolerant healthchecks

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

Version bumps across Dockerfiles (8.1–8.4) for platform tooling, Node stack, and code-server extensions; README Node.js LTS reference updated; test scripts' conditionals and grep patterns adjusted. No structural or control-flow changes.

Changes

Cohort / File(s) Summary
Dockerfiles: version bumps (global & code-server stages)
8.1/Dockerfile, 8.2/Dockerfile, 8.3/Dockerfile, 8.4/Dockerfile
Updated ENV and install references: PLATFORMSH_CLI 5.0.23→5.6.0, YQ 4.47.2→4.48.1, NVM 0.40.2→0.40.3, NODE 22.14.0→22.20.0, CODE_SERVER 4.99.3→4.104.3, VSCODE_GITLENS 17.0.3→17.6.1, VSCODE_XDEBUG 1.36.0→1.37.0. No logic changes.
Docs
README.md
Node.js LTS reference updated: v22.14.0 → v22.20.0.
Tests
tests/test.bats
Replaced Bash-style conditionals with POSIX-style [ numeric comparisons and relaxed several anchored grep patterns to unanchored matches.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • version bumps #338 — Also updates Dockerfile tool version pins (notably YQ_VERSION), closely related to the yq/version bump here.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Version bumps” accurately captures the central change in this pull request, which is updating tool and dependency versions across multiple Dockerfiles, tests, and documentation, and it is concise and specific enough for quick identification in the project history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/version-bumps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7623351 and 211bbec.

📒 Files selected for processing (1)
  • tests/test.bats (7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Build: 8.3/arm64
  • GitHub Check: Build: 8.2/amd64
  • GitHub Check: Build: 8.4/amd64
  • GitHub Check: Build: 8.2/arm64
  • GitHub Check: Build: 8.1/arm64
  • GitHub Check: Build: 8.4/arm64
🔇 Additional comments (2)
tests/test.bats (2)

79-79: LGTM! Improved test assertions.

The migration from [[ ${status} == 0 ]] to [ "$status" -eq 0 ] improves the test assertions:

  • Numeric comparison -eq is more semantically correct for exit codes than string comparison ==
  • Quoting "$status" is safer and follows shell scripting best practices
  • POSIX-style [ test is more portable, though BATS runs in bash by default

Also applies to: 251-271, 306-306, 329-329, 362-362, 406-406, 414-414


195-231: Approve grep pattern relaxations and status check improvements
Unanchored grep patterns match the numeric versions defined in the Dockerfiles even with set -x prefixes, and switching to [ "$status" -eq 0 ] is a safer, more portable numeric check.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
8.4/Dockerfile (1)

165-169: Consistent bumps across tools and code-server stage

Looks good and consistent with README and other Dockerfiles. Suggest running the verification script (see 8.2/Dockerfile comment) and consider adding checksums for downloaded artifacts.

Also applies to: 256-258, 348-351

8.3/Dockerfile (1)

165-169: LGTM: versions aligned; verify availability

Bumps are consistent. Please run the verification script from the 8.2/Dockerfile comment to validate releases, and consider adding checksum verification for the curl-installed binaries.

Also applies to: 256-258, 348-351

8.2/Dockerfile (1)

165-169: Confirm artifact availability and add checksum validation
All tested URLs respond with 301/302, indicating valid artifacts. Integrate checksum verification (e.g., sha256) for each downloaded binary. Optionally, switch code-server downloads to the official coder/code-server host to avoid GitHub redirects.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b339aac and 7623351.

📒 Files selected for processing (5)
  • 8.1/Dockerfile (3 hunks)
  • 8.2/Dockerfile (3 hunks)
  • 8.3/Dockerfile (3 hunks)
  • 8.4/Dockerfile (3 hunks)
  • README.md (1 hunks)
🔇 Additional comments (2)
README.md (1)

73-73: Node version doc sync looks good

Doc reflects Node v22.20.0 LTS, aligned with Dockerfiles.

8.1/Dockerfile (1)

164-165: Aligned version bumps; keep Terminus pin for PHP 8.1

Updates match other images; Terminus remains pinned for PHP 8.1 compatibility. LGTM. Please run the verification script from 8.2/Dockerfile comment to confirm artifact availability.

Also applies to: 169-170, 256-258, 348-351

Check version number only, so we don't have to match up update every time some other text changes in the "tool --version" output
The proper check for bats' "run" command status is [ "$status" -eq 0 ]
See https://bats-core.readthedocs.io/en/stable/writing-tests.html

WTF: How did this work in GitHub Actions all this time?..
@lmakarov lmakarov merged commit 76c21a1 into develop Oct 13, 2025
21 checks passed
@lmakarov lmakarov deleted the feature/version-bumps branch October 13, 2025 11:25
@coderabbitai coderabbitai bot mentioned this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants