-
-
Notifications
You must be signed in to change notification settings - Fork 45
Version bumps #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bumps #339
Conversation
- code-server 4.99.3 => 4.104.3 - gitlens 17.0.3 => 17.6.1 - xdebug 1.36.0 => 1.37.0
📝 WalkthroughWalkthroughVersion bumps across Dockerfiles (8.1–8.4) for platform tooling, Node stack, and code-server extensions; README Node.js LTS reference updated; test scripts' conditionals and grep patterns adjusted. No structural or control-flow changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
8.4/Dockerfile (1)
165-169: Consistent bumps across tools and code-server stageLooks good and consistent with README and other Dockerfiles. Suggest running the verification script (see 8.2/Dockerfile comment) and consider adding checksums for downloaded artifacts.
Also applies to: 256-258, 348-351
8.3/Dockerfile (1)
165-169: LGTM: versions aligned; verify availabilityBumps are consistent. Please run the verification script from the 8.2/Dockerfile comment to validate releases, and consider adding checksum verification for the curl-installed binaries.
Also applies to: 256-258, 348-351
8.2/Dockerfile (1)
165-169: Confirm artifact availability and add checksum validation
All tested URLs respond with 301/302, indicating valid artifacts. Integrate checksum verification (e.g., sha256) for each downloaded binary. Optionally, switch code-server downloads to the official coder/code-server host to avoid GitHub redirects.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
8.1/Dockerfile(3 hunks)8.2/Dockerfile(3 hunks)8.3/Dockerfile(3 hunks)8.4/Dockerfile(3 hunks)README.md(1 hunks)
🔇 Additional comments (2)
README.md (1)
73-73: Node version doc sync looks goodDoc reflects Node v22.20.0 LTS, aligned with Dockerfiles.
8.1/Dockerfile (1)
164-165: Aligned version bumps; keep Terminus pin for PHP 8.1Updates match other images; Terminus remains pinned for PHP 8.1 compatibility. LGTM. Please run the verification script from 8.2/Dockerfile comment to confirm artifact availability.
Also applies to: 169-170, 256-258, 348-351
Check version number only, so we don't have to match up update every time some other text changes in the "tool --version" output
The proper check for bats' "run" command status is [ "$status" -eq 0 ] See https://bats-core.readthedocs.io/en/stable/writing-tests.html WTF: How did this work in GitHub Actions all this time?..
Summary by CodeRabbit
Chores
Documentation
Tests