Skip to content

Conversation

@ljcbaby
Copy link
Collaborator

@ljcbaby ljcbaby commented Oct 4, 2025

No description provided.

@ljcbaby ljcbaby requested a review from Copilot October 4, 2025 14:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for IBGP (Internal BGP) route reflector (RR) configurations in BIRD routing daemon, enhancing the existing IBGP setup with route reflection capabilities.

  • Introduces new template configurations for IBGP route reflectors
  • Adds protocol definitions for RR server-to-client relationships
  • Updates existing IBGP configuration to use "next hop self ebgp" setting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
bird/ibgp_rrs.conf New configuration file defining IBGP route reflector templates and protocols
bird/ibgp.conf Updated next hop self setting to include ebgp parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ljcbaby ljcbaby requested a review from BaiMeow October 4, 2025 14:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ljcbaby ljcbaby requested a review from Potat0000 October 4, 2025 15:07
@ljcbaby
Copy link
Collaborator Author

ljcbaby commented Oct 5, 2025

@BaiMeow 调了,再看看,目前应该是有三个性质的模板

@BaiMeow
Copy link
Contributor

BaiMeow commented Oct 5, 2025

add paths rr那只发不收,叶子路由只收不发

@ljcbaby
Copy link
Collaborator Author

ljcbaby commented Oct 5, 2025

add paths rr那只发不收,叶子路由只收不发

没错啊,rr开tx,rr client开rx

@BaiMeow
Copy link
Contributor

BaiMeow commented Oct 5, 2025

template bgp ibgp_peers 是用于 fullmesh 的吗,无需 add paths

@ljcbaby
Copy link
Collaborator Author

ljcbaby commented Oct 5, 2025

lc 感觉不太对劲,可能得再看看

@ljcbaby
Copy link
Collaborator Author

ljcbaby commented Oct 5, 2025

template bgp ibgp_peers 是用于 fullmesh 的吗,无需 add paths

同集群的rr之间互联,确实是fullmesh,rr反射到非客户端

@ljcbaby
Copy link
Collaborator Author

ljcbaby commented Oct 5, 2025

lc 感觉不太对劲,可能得再看看

主要是 RR 不一定就是内部路由,也有可能同时还是边缘路由器的

Updated BGP templates and protocols to include dn11_update_server_location function in export filters.
@BaiMeow
Copy link
Contributor

BaiMeow commented Oct 5, 2025

还有个问题,rr 收到的 ebgp 在发给 rr client 也需要打地理信息,暂时还不知道怎么打,可能可以尝试判断是否存在本 as 的 geo 没有就打

也可以放 input 打但是要重新审一遍 update cross 看看会不会出问题

Copy link
Contributor

@BaiMeow BaiMeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能需要文档标注当前配法的优缺点,内存开销缺陷,备份优势

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants