Skip to content

Conversation

@ulgens
Copy link
Member

@ulgens ulgens commented Dec 4, 2025

No description provided.

@ulgens ulgens force-pushed the update-test-matrix branch from 3865fec to e05da58 Compare December 4, 2025 03:07
@ulgens ulgens marked this pull request as draft December 4, 2025 03:08
@ulgens ulgens force-pushed the update-test-matrix branch 2 times, most recently from cf9545d to 40efc63 Compare December 4, 2025 03:50
@ulgens ulgens marked this pull request as ready for review December 4, 2025 04:14
@ulgens ulgens changed the title Add all supported Django version to the test matrix Add support for Django 6.0 Dec 4, 2025
@DhavalGojiya
Copy link
Member

DhavalGojiya commented Dec 4, 2025

Oh no, there is also issue here.
Line:107 and Line:119

shell: bash
run: |
if [ ${{ matrix.broker == 'valkey' }} == true ]; then
additional_args="--extra valkey"
fi
uv sync --extra yaml $additional_args
uv pip install django==${{ matrix.django-version }}
- name: Get version
id: getVersion
shell: bash
run: |
VERSION=$(uv version --short)
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
- name: Check for missing migrations
run: |
cd testproject
uv run python manage.py makemigrations --check
- name: Run Tests without coverage
if: ${{ matrix.coverage != 'yes' }}
run: |
cd testproject
export FAKEREDIS=${{ matrix.broker == 'fakeredis' }}
if [ ${{ matrix.broker == 'valkey' }} == true ]; then
export BROKER_PORT=6380
else
export BROKER_PORT=6379
fi
uv run python manage.py test --exclude-tag multiprocess scheduler

When Line:119 uv run executed it make sures the environment is sync with uv.lock and since uv.lock currently has :

[[package]]
name = "django"
version = "5.2.7"

Whatever we did here in Line:107 is reverted from .venv environment.
We need to add uv run --no-sync or uv run --with django==${{ matrix.django-version }} in Line:119 and Line:131

@cunla
Copy link
Member

cunla commented Dec 4, 2025

Oh no, there is also issue here. Line:107 and Line:119

shell: bash
run: |
if [ ${{ matrix.broker == 'valkey' }} == true ]; then
additional_args="--extra valkey"
fi
uv sync --extra yaml $additional_args
uv pip install django==${{ matrix.django-version }}
- name: Get version
id: getVersion
shell: bash
run: |
VERSION=$(uv version --short)
echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
- name: Check for missing migrations
run: |
cd testproject
uv run python manage.py makemigrations --check
- name: Run Tests without coverage
if: ${{ matrix.coverage != 'yes' }}
run: |
cd testproject
export FAKEREDIS=${{ matrix.broker == 'fakeredis' }}
if [ ${{ matrix.broker == 'valkey' }} == true ]; then
export BROKER_PORT=6380
else
export BROKER_PORT=6379
fi
uv run python manage.py test --exclude-tag multiprocess scheduler

When Line:119 uv run executed it make sures the environment is sync with uv.lock and since uv.lock currently has :

[[package]]
name = "django"
version = "5.2.7"

Whatever we did here in Line:107 is reverted from .venv environment. We need to add uv run --no-sync or uv run --with django==${{ matrix.django-version }} in Line:119 and Line:131

Run locally uv sync --all-extras --upgrade and it will update uv.lock - include uv.lock in your commit.

@DhavalGojiya
Copy link
Member

Run locally uv sync --all-extras --upgrade and it will update uv.lock - include uv.lock in your commit.

But this will not resolve the issue.
We use dynamic Django version via matrix variable.
The moment uv run executed it again sync environment with whatever Django version defined inside uv.lock
The solution is to use --with flag with uv run OR --no-sync

@ulgens
Copy link
Member Author

ulgens commented Dec 4, 2025

I think it will be better to handle "5.2.5" -> "5.2" change and afformentioned lock issues in a different PR. I'll create that, but can't promise to do it asap.

@ulgens ulgens force-pushed the update-test-matrix branch from d796a4f to 7c814c5 Compare December 4, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants