Document registry_enabled limitation and add tests #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #433
This PR addresses the confusion around the
registry_enabledfield in Kubernetes cluster creation. The field is read-only in the API and cannot be set during cluster creation.Problem
Users expect to be able to pass
registry_enabled: Truewhen creating a Kubernetes cluster, but this parameter is ignored because it's a read-only field in the API response.Solution
This PR:
The Correct Approach
To enable container registry integration with a Kubernetes cluster:
Changes
test_kubernetes_cluster_registry_integrationintegration testtest_kubernetes_cluster_with_registry_integrationmocked testTesting
All existing tests continue to pass, and the new tests verify the correct behavior.