Add a Rust matcher for OpenID4VCI creation requests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QZHelen
reviewed
Dec 2, 2025
QZHelen
reviewed
Dec 2, 2025
| serde_json::from_slice(&matcher_data_buffer[json_start.try_into()?..])?; | ||
| let request: DigitalCredentialCreationRequest = | ||
| serde_json::from_slice(&credman.get_request_buffer())?; | ||
| if request.requests.iter().any(|r| { |
Contributor
There was a problem hiding this comment.
We should also allow filtering based on the following of the issuer offer, and have the wallet / holder provide their supported values as part of the data:
- credential_issuer
- credential_configurations_supported.format and other xyz_supported values
Author
There was a problem hiding this comment.
These are all in the issuance_matchers.rs file
netheril96
force-pushed
the
rs
branch
2 times, most recently
from
dbb556b to
1065df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Rust matcher for OpenID4VCI creation requests.
We've added only a few types of filters. More can be added later.