Skip to content

Conversation

@sei-vsarvepalli
Copy link
Contributor

Basic test case for Issue #1127 already resolved in last PR #1128 as requested in #1129

This is entirely optional test case to ensure we have reliable test cases for this issue that was raised by @dmitrc

@davidlehn
Copy link
Member

  • I think this is probably better in tests/unit/pkcs12.js with the other related tests? Maybe with a comment it was for issue 1127.
  • Remove the async. Not needed here and it breaks the silly check we have for node 6(!).

@sei-vsarvepalli
Copy link
Contributor Author

  • I think this is probably better in tests/unit/pkcs12.js with the other related tests? Maybe with a comment it was for issue 1127.
  • Remove the async. Not needed here and it breaks the silly check we have for node 6(!).

Updated the test as requested by David Lehn.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.18%. Comparing base (194988d) to head (fd07474).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   80.20%   80.18%   -0.03%     
==========================================
  Files          42       42              
  Lines        9575     9575              
==========================================
- Hits         7680     7678       -2     
- Misses       1895     1897       +2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194988d...fd07474. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidlehn davidlehn merged commit 175a6d4 into digitalbazaar:main Dec 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants