-
Notifications
You must be signed in to change notification settings - Fork 4
Story/cite 217 - It should be possible to create personal access tokens #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Can one of the admins verify this patch? |
| <artifactId>mockito-core</artifactId> | ||
| <version>3.12.4</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of the code related to personal access tokens should be in its own manager class not mixed in with the oauth clients. Also, I think we want only one OAuthClient (for the user) and then create multiple access token for the client, rather than multiple oauthclients. Or is there a reason to have one client per token? and then finally, I think I would consider creating a subclass for oauthclient for personal access tokens, rather than a boolean flag. but is that flag really needed? it looks like it's only used once, and with a separate manager class, it might not be necessary?
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
It should be possible to create personal access tokens
... Put ticket description here and add link to ticket ...
A user should be able to create personal access tokens that they can use to use the Citesphere API. The tokens should only allow access to their own data (like any token retrieved via the authorization code flow). After being generated, a token should be visible once, after that the user can only regenerate a token if they loose it. It should be possible to delete tokens.
https://diging.atlassian.net/browse/CITE-217
Are there any other pull requests that this one depends on?
diging/citesphere-model#58
Anything else the reviewer needs to know?
... describe here ...