Skip to content

Conversation

@pietrodimarco-dfinity
Copy link
Contributor

No description provided.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner October 22, 2025 22:18
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Update dependencies chore: Update IC dependencies Oct 22, 2025
cursor[bot]

This comment was marked as outdated.

@pietrodimarco-dfinity pietrodimarco-dfinity changed the title chore: Update IC dependencies chore: Update IC dependencies + rust toolchain Oct 23, 2025
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Catch-All Pattern Disables Exhaustiveness Checking

The added catch-all pattern removes compile-time exhaustiveness checking for NnsFunction variants. Unhandled proposal types now silently return empty JSON instead of failing, which can mask missing implementations for new proposal types and lead to incomplete data without error indication.

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

MSD Diff

No diff

@dfinity dfinity deleted a comment from cursor bot Oct 23, 2025
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Configuration Error

In init_logger, the default logging level is set using RUST_LOG instead of LOG_LEVEL. This prevents the logger from picking up the intended default configuration, as it expects the LOG_LEVEL environment variable.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Configuration Conflicts with Environment Variable

The init_logger function at line 63 sets the default logging level to RUST_LOG. This is inconsistent with the logger's configuration, which reads from LOG_LEVEL, preventing default logging settings from applying.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Configuration Overwrites Default Setting

In init_logger, line 63 sets the RUST_LOG environment variable instead of LOG_LEVEL when neither RUST_LOG nor LOG_LEVEL is initially set. This prevents the intended default logging configuration from being applied.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Initialization Inconsistency

The init_logger function sets the RUST_LOG environment variable as a fallback, but the logger initialization expects LOG_LEVEL. This prevents the default logging configuration from being applied and is inconsistent with the Ok branch, which correctly sets LOG_LEVEL.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Configuration Error

Line 63 sets the RUST_LOG environment variable instead of LOG_LEVEL. This change is inconsistent with the logger's initialization logic, preventing default logging levels from being applied as intended.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logging Configuration Mismatch

The fallback logging configuration on line 63 sets RUST_LOG instead of LOG_LEVEL. Since the logger is initialized using LOG_LEVEL, it won't pick up these default settings, leading to unintended logging behavior. This also creates an inconsistency with the LOG_LEVEL setting on line 57.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Initialization Overwrites Default Configuration

In init_logger, the fallback logic now sets the RUST_LOG environment variable instead of LOG_LEVEL. This prevents the default logging configuration from taking effect, as the logger is initialized using LOG_LEVEL.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Environment Variable Handling Inconsistency

The init_logger function has an inconsistency in its environment variable handling. When RUST_LOG and LOG_LEVEL are unset, the fallback logic now sets RUST_LOG instead of LOG_LEVEL. This prevents the default logging configuration from being applied, as the logger expects LOG_LEVEL.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Fallback Sets Incorrect Environment Variable

In init_logger, when RUST_LOG and LOG_LEVEL aren't set, the fallback logic incorrectly sets the RUST_LOG environment variable instead of LOG_LEVEL. This prevents the default logging configuration from being applied, as the logger expects LOG_LEVEL.

Fix in Cursor Fix in Web

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Initialization Inconsistency

The default logger initialization sets RUST_LOG instead of LOG_LEVEL. This inconsistency with other LOG_LEVEL assignments means the default logging level won't apply when neither RUST_LOG nor LOG_LEVEL are already set.

Fix in Cursor Fix in Web

@pietrodimarco-dfinity pietrodimarco-dfinity enabled auto-merge (squash) October 23, 2025 08:17
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Initialization Ignores Default Configuration

In init_logger, the default logging level is set to RUST_LOG on line 63 instead of LOG_LEVEL. This creates an inconsistency with the LOG_LEVEL check on line 59 and the logger's initialization on line 67, preventing the default logging configuration from being applied correctly.

Fix in Cursor Fix in Web

Copy link
Collaborator

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dfinity dfinity deleted a comment from cursor bot Oct 23, 2025
@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Logger Configuration Error

The init_logger function's fallback logic sets the RUST_LOG environment variable instead of LOG_LEVEL. This inconsistency means the default logging configuration isn't applied, as the logger expects LOG_LEVEL.

Fix in Cursor Fix in Web

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit da774e3 into main Oct 23, 2025
14 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the update-toolchain-and-dep branch October 23, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants