Fix for issue 4 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc: @manuraj17 |
Contributor
Author
|
@manuraj17 Any reasons for not merging this PR? |
Collaborator
|
@devsks I was just thinking over the type column, although I feel it might be not of that great use I also see that it could be useful at some time, so I am just keeping it on hold to see if this will be required. Thanks for the work though, I will keep this issue open and if need comes I will merge it, you can have this branch rebased then. Ok? |
Contributor
Author
|
ok @manuraj17 no problem. But don't you think that if we add the "type" column later on then we will have to add type values of existing books? we will have to add a lot of values to fill the "type" column. |
Collaborator
|
@devsks You are right, it will be a task. I will get this sorted soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the 'type' column in respective README.md files and added values to already added books.