Skip to content

feat: Container name fix #6878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirandevtn wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −10
Open

feat: Container name fix #6878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b8035
added namesapce for vs and dr
kirandevtn Nov 21, 2025
4d915c1
Merge branch 'main' of https://github.com/devtron-labs/devtron
kirandevtn Dec 1, 2025
7014ca9
Changed container name in case of nameOverride
kirandevtn Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ spec:
initContainers:
{{- range $i, $c := .Values.initContainers }}
{{- if .reuseContainerImage}}
- name: {{ $.Chart.Name }}-init-{{ add1 $i }}
- name: {{ template ".Chart.Name .name" $ }}-init-{{ add1 $i }}
image: "{{ $.Values.server.deployment.image }}:{{ $.Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if .securityContext }}
Expand Down Expand Up @@ -209,7 +209,7 @@ spec:
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}
- name: {{ template ".Chart.Name .name" $ }}
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if $.Values.containerSpec.lifecycle.enabled }}
Expand Down Expand Up @@ -540,7 +540,7 @@ spec:
{{- if $.Values.containers }}
{{- range $i, $c := .Values.containers }}
{{- if .reuseContainerImage}}
- name: {{ $.Chart.Name }}-sidecontainer-{{ add1 $i }}
- name: {{ template ".Chart.Name .name" $ }}-sidecontainer-{{ add1 $i }}
image: "{{ $.Values.server.deployment.image }}:{{ $.Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if .env }}
Expand Down Expand Up @@ -795,7 +795,7 @@ spec:
initContainers:
{{- range $i, $c := .Values.initContainers }}
{{- if .reuseContainerImage}}
- name: {{ $.Chart.Name }}-init-{{ add1 $i }}
- name: {{ template ".Chart.Name .name" $ }}-init-{{ add1 $i }}
image: "{{ $.Values.server.deployment.image }}:{{ $.Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if .securityContext }}
Expand Down Expand Up @@ -825,7 +825,7 @@ spec:
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}
- name: {{ template ".Chart.Name .name" $ }}
image: "{{ .Values.server.deployment.image }}:{{ .Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if $.Values.containerSpec.lifecycle.enabled }}
Expand Down Expand Up @@ -1156,7 +1156,7 @@ spec:
{{- if $.Values.containers }}
{{- range $i, $c := .Values.containers }}
{{- if .reuseContainerImage}}
- name: {{ $.Chart.Name }}-sidecontainer-{{ add1 $i }}
- name: {{ template ".Chart.Name .name" $ }}-sidecontainer-{{ add1 $i }}
image: "{{ $.Values.server.deployment.image }}:{{ $.Values.server.deployment.image_tag }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
{{- if .env }}
Expand Down
8 changes: 4 additions & 4 deletions scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/templates/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ spec:
- type: ContainerResource
containerResource:
name: cpu
container: {{ $.Chart.Name }}
container: {{ template ".Chart.Name .name" $ }}
target:
type: Utilization
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
Expand All @@ -52,7 +52,7 @@ spec:
- type: ContainerResource
containerResource:
name: memory
container: {{ $.Chart.Name }}
container: {{ template ".Chart.Name .name" $ }}
target:
type: Utilization
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
Expand Down Expand Up @@ -126,7 +126,7 @@ spec:
- type: ContainerResource
containerResource:
name: cpu
container: {{ $.Chart.Name }}
container: {{ template ".Chart.Name .name" $ }}
target:
type: Utilization
averageUtilization: {{ .TargetCPUUtilizationPercentage }}
Expand All @@ -135,7 +135,7 @@ spec:
- type: ContainerResource
containerResource:
name: memory
container: {{ $.Chart.Name }}
container: {{ template ".Chart.Name .name" $ }}
target:
type: Utilization
averageUtilization: {{ .TargetMemoryUtilizationPercentage }}
Expand Down
Loading