Improve JBoss EAP detection #284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haoozhang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
Hi @elsony @michael-valdron @Jdubrick @thepetk , could you please help to review this PR, thanks! |
added 2 commits
December 9, 2025 19:51
Signed-off-by: HaoZhang <haozhan@microsoft.com>
Signed-off-by: HaoZhang <haozhan@microsoft.com> # Conflicts: # test/apis/component_recognizer_test.go
haoozhang
force-pushed
the
haozhan/jboss-eap
branch
from
22b1e15 to
4446a33
Compare
Signed-off-by: HaoZhang <haozhan@microsoft.com>
haoozhang
force-pushed
the
haozhan/jboss-eap
branch
from
99dbe30 to
51c2b44
Compare
Contributor
|
Hey @haoozhang! Thank you for your PR! I'll take a look in the next days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR is to improve the detection of JBoss EAP framework.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
[x] For each added clue, add the test project and unit test to verify it.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.
References