Skip to content

Conversation

@gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Dec 13, 2024

Ref: #1202

Feature Name

  • Docker-in-docker

Description

changelog

  • Have pinned the docker-ce and docker-ce-cli to the configured versions for the feature

Checklist

  • Checked that applied changes work as expected

…holds configured docker-ce and docker-ce-cli version
@gauravsaini04 gauravsaini04 requested a review from a team as a code owner December 13, 2024 04:43
@gauravsaini04 gauravsaini04 marked this pull request as draft December 13, 2024 09:58
@gauravsaini04 gauravsaini04 marked this pull request as ready for review December 18, 2024 04:14
@thediveo
Copy link

Can this please be moved forward, as I'm also blocked in a slightly different use case compared to #1202 where I want to install multiple Docker versions into a dev container, activating only exactly one after another as needed. We want to use this to work on and test upgrade use cases. Currently, the unwanted upgrade makes installing a precise Docker version impossible as far as I can tell from my logs.

Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

@ddoyle2017 ddoyle2017 merged commit c31723d into devcontainers:main Jan 28, 2025
112 checks passed
@gauravsaini04 gauravsaini04 deleted the docker-in-docker_issue_#1202_solution branch January 29, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants