Oryx Issue #1181
Oryx Issue #1181
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@Mathiyarasy please take a look at failing checks/tests |
|
Looked into the failing tests
In test scenarios oryx install_dotnet_and_oryx fails at test case 'two versions of dotnet runtimes are present'. |
|
We should update the feature version as well, right? @Mathiyarasy |
| if [ -n "${RUNTIME_VERSIONS:-}" ]; then | ||
| SDK_INSTALLED_RUNTIME=$(echo "$NEW_RUNTIME_VERSIONS" | grep -vxFf <(echo "$RUNTIME_VERSIONS")) | ||
| else | ||
| SDK_INSTALLED_RUNTIME="$NEW_RUNTIME_VERSIONS" |
There was a problem hiding this comment.
Are there cases where more than one sdk is installed? I see plural NEW_RUNTIME_VERSIONS
In that case SDK_INSTALLED_RUNTIME may get assigned a multiline string? Wouldn't that case issues with deletions on the lines below?
There was a problem hiding this comment.
No we install only one sdk as a part of oryx and this is installing only one runtime
It is in plural because for images with dotnet even before oryx they sometime might have multiple runtimes from those runtimes we pick only the runtime installed from oryx feature.
There was a problem hiding this comment.
In that case should the naming be updated to avoid the confusion?
I will go ahead and checkin this PR, you may followup with a PR if needed
2 participants
Universal Image Latest Version: Caused issue in a Pipeline
Azure DevOps Pipeline generate-kitchensink-automated Failed
This PR aims to do things: