Skip to content

Conversation

@Carreau
Copy link
Collaborator

@Carreau Carreau commented Dec 17, 2025

This seem ti was a bug; but the default seem to be to always return 0, maybe should be changed ?

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.30%. Comparing base (41733ec) to head (2f058bd).
⚠️ Report is 224 commits behind head on master.

Files with missing lines Patch % Lines
lib/python/pyflyby/_cmdline.py 10.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (41733ec) and HEAD (2f058bd). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (41733ec) HEAD (2f058bd)
10 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #463       +/-   ##
===========================================
- Coverage   67.97%   56.30%   -11.68%     
===========================================
  Files          25       29        +4     
  Lines        8012     8751      +739     
===========================================
- Hits         5446     4927      -519     
- Misses       2566     3824     +1258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Carreau Carreau force-pushed the exit-code branch 2 times, most recently from 749494f to c596580 Compare December 17, 2025 13:15
@Carreau
Copy link
Collaborator Author

Carreau commented Dec 19, 2025

consensus was to not change the default and keep this as-is

This seem ti was a bug; but the default seem to be to always return 0,
maybe should be changed ?
@Carreau Carreau merged commit bfdb267 into deshaw:master Jan 5, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant