Fix newsletter week number calculation #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newsletter covers Sunday to Saturday, but ISO week numbers change on Monday. Previously the code used Sunday's week number which could result in showing the previous week's number. Now it correctly uses Monday's week number for consistency. Changes: - Extract date calculation into testable calculateNewsletterWeek function - Add NewsletterWeek struct to hold all week information - Use Monday's ISOWeek() for year and week number - Add comprehensive tests including year transition edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newsletter covers Sunday to Saturday, but ISO week numbers change on Monday. Previously the code used Sunday's week number which could result in showing the previous week's number. Now it correctly uses Monday's week number for consistency.
Changes: