Constant first part #582
Closed
Constant first part #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
Contributor
thehoul
reviewed
Nov 10, 2025
thehoul
requested changes
Nov 11, 2025
There was a problem hiding this comment.
Also, see comments from Yolan on #579, a lot of them still apply.
There are quite a lot of comments that require some input from @pierluca @jbsv, If you can go through my comments and answer to the one you have answers to, it would help a lot :)
Edit: actually if @ValeriodeSa you could look at the comments as well and answer those that you can, it would be nice :P
thehoul
added a commit
that referenced
this pull request
Nov 12, 2025
thehoul
force-pushed
the
int32-repro-original
branch
from
a9173e5 to
537820e
Compare
thehoul
reviewed
Nov 12, 2025
thehoul
reviewed
Nov 12, 2025
There was a problem hiding this comment.
This should be removed (all the changes below are reverted in #579 )
thehoul
force-pushed
the
constantFirstPart
branch
2 times, most recently
from
dd5d437 to
f1fd094
Compare
|
|
thehoul
force-pushed
the
constantFirstPart
branch
2 times, most recently
from
71995d3 to
919fa0b
Compare
thehoul
reviewed
Nov 18, 2025
thehoul
reviewed
Nov 18, 2025
jbsv
pushed a commit
that referenced
this pull request
Nov 19, 2025
jbsv
force-pushed
the
int32-repro-original
branch
2 times, most recently
from
8e9bdc2 to
fa56084
Compare
thehoul
force-pushed
the
constantFirstPart
branch
from
0d0eb77 to
7fb25aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #581