Minows uses a DB to handle keys #306
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15610563053Details
💛 - Coveralls |
ineiti
reviewed
Jun 5, 2025
test/cosidela_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| onet, err = minows.NewMinows(listen, nil, &db) | ||
| onet, err = minows.NewMinows(listen, nil, db, port) |
Member
There was a problem hiding this comment.
Why is the port used as index for the key?
Member
|
Why? What is the reason for this PR? Is there an issue attached to it? From what I see, the private key index is only used in the tests. I propose to change the tests to use one db per instance, so you don't need to have a key-index. Because you'll also have other data in the db, so you'll need multiple dbs anyway. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.