Skip to content

Conversation

@RottenRat
Copy link
Contributor

@RottenRat RottenRat commented Jan 12, 2026

Fix unnecessary error test
Case:

updateMode: "Auto"

Before:

🐒 [vpa (#templates)]
     Message:     Getting vpa containers name list for the object failed: {Deployment virt-operator d8-virtualization}
     Module:      virtualization
     Object:      kind = Deployment ; name = virt-operator ; namespace = d8-virtualization

🐒 [vpa (#templates)]
     Message:      VPA updateMode cannot be 'Auto'
     Module:       virtualization
     Object:       kind = VerticalPodAutoscaler ; name = cdi-deployment ; namespace = d8-virtualization
     FilePath:     templates/cdi/cdi-deployment/vpa.yaml

After:

🐒 [vpa (#templates)]
     Message:     Getting vpa containers name list for the object failed: {Deployment virt-operator d8-virtualization}
     Module:      virtualization
     Object:      kind = Deployment ; name = virt-operator ; namespace = d8-virtualization

The extra error has been removed as it should be.

Add updateMode value check tests:
Case:

updateMode: "imagination"

Before:
OK
After:

🐒 [vpa (#templates)]
     Message:      Invalid updateMode 'imagination'. Allowed values are: Off, Initial, Recreate, InPlaceOrRecreate
     Module:       virtualization
     Object:       kind = VerticalPodAutoscaler ; name = virt-controller ; namespace = d8-virtualization
     FilePath:     templates/kubevirt/virt-controller/vpa.yaml

The UpdateMode values are now checked for validity.

Sinelnikov Michail added 2 commits January 12, 2026 14:51
fix
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
@RottenRat RottenRat self-assigned this Jan 12, 2026
fix
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
@RottenRat RottenRat changed the title VPA Unnecessary error fix and add updateMode value check VPA Unnecessary error fix and add updateMode value validation Jan 12, 2026
@RottenRat RottenRat requested a review from ldmonster January 12, 2026 12:44
@RottenRat RottenRat marked this pull request as ready for review January 12, 2026 12:44
@ldmonster ldmonster merged commit 1ed6534 into main Jan 12, 2026
3 checks passed
@ldmonster ldmonster deleted the auto-plus-error branch January 12, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants