Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

Proposed changes

Eliminates code duplication between CustomSelect components and native select ::picker pseudo-element by extracting common styles into shared SCSS placeholders.

Created: packages/components/src/styles/internal/_select-dropdown-components.scss

  • %select-dropdown-container - Dropdown positioning, shadow, sizing, background
  • %select-list-container - Overflow behavior and max-height calculation
  • %select-list-item - Base item styles (padding, background, border-radius)
  • %select-list-item-interaction - Hover/active states

Updated components to extend placeholders:

  • select.scss - ::picker(select) and option elements
  • custom-select-dropdown.scss - Dropdown container
  • custom-select-list.scss - List container
  • custom-select-list-item.scss - List items

Reduces ~50 lines of duplicated styles while ensuring consistency across both implementations.

resolves #3654

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Single source of truth for select dropdown/list styling. Future modifications only need to occur in one location.

❤️ Thank you!


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/copilot/sub-pr-4624

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: db45ad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI and others added 2 commits December 5, 2025 21:50
…ceholders

Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
Co-authored-by: mfranzke <787658+mfranzke@users.noreply.github.com>
Copilot AI changed the title [WIP] Add native select styling for better user experience refactor: extract shared select dropdown/list styles into central SCSS placeholders Dec 5, 2025
Copilot AI requested a review from mfranzke December 5, 2025 21:54
Copilot finished work on behalf of mfranzke December 5, 2025 21:54
github-actions bot and others added 3 commits December 6, 2025 06:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

2 participants