Skip to content

feat: adapt CustomSelect styles to native select ::picker pseudo-element #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfranzke merged 4 commits into from
Dec 5, 2025
Merged

feat: adapt CustomSelect styles to native select ::picker pseudo-element #5585

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6a5da5
Initial plan
Copilot Dec 5, 2025
20ea657
feat: adapt CustomSelect styles to native select picker
Dec 5, 2025
be950f3
refactor: remove redundant overflow-y property
Dec 5, 2025
2ce6e69
docs: improve comments for option height calculation
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion packages/components/src/components/select/select.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
@use "@db-ux/core-foundations/build/styles/colors";
@use "@db-ux/core-foundations/build/styles/icons";
@use "@db-ux/core-foundations/build/styles/fonts";
@use "@db-ux/core-foundations/build/styles/helpers";
@use "../../styles/internal/form-components";
@use "../../styles/internal/component";
@use "../../styles/internal/select-components";
Expand Down Expand Up @@ -67,18 +68,64 @@
/* stylelint-disable-next-line selector-pseudo-element-no-unknown */
:is(::picker(select)) {
@extend %default-card;

// Adapted from .db-custom-select-dropdown
position: absolute;
z-index: 32;
box-shadow: variables.$db-elevation-md;
min-inline-size: variables.$db-sizing-xl;
max-inline-size: calc(
100vw - 2 * #{variables.$db-spacing-fixed-sm}
);

// Adapted from .db-card
background-color: colors.$db-adaptive-bg-basic-level-1-default;
padding: variables.$db-spacing-fixed-sm;

// Adapted from .db-custom-select-list
overflow-block: auto;

/* (option height + padding) * 5.5 items (showing partial item to indicate more content) + list padding */
max-block-size: calc(
5.5 *
(
(
#{form-components.$font-size-height} - 2 *
#{variables.$db-border-width-3xs}
) +
2 * #{variables.$db-spacing-fixed-sm}
) +
(#{variables.$db-spacing-fixed-sm} * 2)
);
}

option {
// Adapted from .db-custom-select-list-item
position: relative;
padding: variables.$db-spacing-fixed-sm;
background-color: colors.$db-adaptive-bg-basic-transparent-full-default;
border-radius: variables.$db-border-radius-xs;
box-sizing: border-box;
justify-content: space-between;

// change order of the included text and pseudo-element within this flexbox item, to make sure the icon is always on the right
flex-direction: row-reverse;

&:checked {
font-weight: 700;
}

// Hover states adapted from .db-custom-select-list-item
&:not(:checked) {
@include helpers.hover {
background-color: colors.$db-adaptive-bg-basic-transparent-full-hovered;
}

@include helpers.active {
background-color: colors.$db-adaptive-bg-basic-transparent-full-pressed;
}
}

/* stylelint-disable-next-line selector-pseudo-element-no-unknown */
:is(&::checkmark) {
@extend %icon;
Expand Down
Loading