Skip to content

fix(dbinput): inserting an empty string doesn't reset date form fields #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfranzke merged 6 commits into from
Nov 26, 2025
Merged

fix(dbinput): inserting an empty string doesn't reset date form fields #5440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f270c6
docs: adapted solution
mfranzke Nov 11, 2025
fc4cdc1
fix(input[type="date"]): resetting a field by the empty string
mfranzke Nov 11, 2025
db1ffc3
Create orange-eyes-pump.md
mfranzke Nov 11, 2025
a7129d0
Clarify behavior of DBInput with empty string input
mfranzke Nov 11, 2025
e1d351a
Merge branch 'main' into 5439-dbinput-inserting-an-empty-string-doesn…
michaelmkraus Nov 17, 2025
08691bf
Merge branch 'main' into 5439-dbinput-inserting-an-empty-string-doesn…
mfranzke Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-eyes-pump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@db-ux/ngx-core-components": patch
---

DBInput: inserting an empty string doesn't reset/empty date or time related form fields
2 changes: 1 addition & 1 deletion packages/components/scripts/post-build/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ export const getComponents = (): Component[] => [
from: 'writeValue(value: any) {',
to:
'writeValue(value: any) {\n' +
'if (!value && (this.type() === "date" ||\n' +
'if (!value && value !== "" && (this.type() === "date" ||\n' +
' this.type() === "time" ||\n' +
' this.type() === "week" ||\n' +
' this.type() === "month" ||\n' +
Expand Down
2 changes: 1 addition & 1 deletion showcases/angular-showcase/src/app/components/form/form.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export class FormComponent {
this.model.checkbox2 = false;
this.form.get('input')?.setValue('reset');
this.form.get('textarea')?.setValue('reset');
this.form.get('dateinput')?.setValue('reset');
this.form.get('dateinput')?.setValue('');
this.form.get('checkbox')?.setValue(false);
}

Expand Down