Skip to content

Conversation

@mimuret
Copy link

@mimuret mimuret commented Dec 7, 2023

The default value of range_end is defined as an empty string in Etcdv3::Namespace::KV.del.
However, nil is assumed in Etcdv3::Namespace::KV::Requests.del_request, creating an inconsistency.
Therefore, if range_end is not specified, namespace is assigned to range_end and del will not work correctly.

@davissp14
Copy link
Owner

davissp14 commented Dec 7, 2023

Looks like we need to move the tests to github actions. In any case, would you mind adding a test to cover this?

@mimuret
Copy link
Author

mimuret commented Dec 8, 2023

Test added.
test results on local before fix below,

  1) Etcdv3 Insecure connection without Auth namespace #del no range was deleted
     Failure/Error: expect(resp.deleted).to eq(1)
     
       expected: 1
            got: 0
     
       (compared using ==)
     # ./spec/etcdv3_spec.rb:583:in `block (6 levels) in <top (required)>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants