Skip to content

Please consider the following formatting changes to #14800 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 2 commits into from
Closed

Please consider the following formatting changes to #14800 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51fec69
GPU QA: Make some of the plots nices
davidrohr Nov 7, 2025
ba39f08
Please consider the following formatting changes
alibuild Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions GPU/GPUTracking/Definitions/GPUSettingsList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,7 @@ AddOption(histMaxNClusters, uint32_t, 500000000, "", 0, "Maximum number of clust
AddOption(minNClFindable, uint32_t, 70, "", 0, "Minimum number of (weighted) MC clusters for a track to count as findable")
AddOption(minNClEff, uint32_t, 10, "", 0, "Minimum number of (weighted) MC clusters for a track to contribute to all-tracks efficiency histogramm")
AddOption(minNClRes, uint32_t, 40, "", 0, "Minimum number of (weighted) MC clusters for a track to contribute to resolution histogram")
AddOption(perfFigure, int32_t, 0, "", 0, "Show as performance figure, positive value for MC, negative value for data")
AddShortcut("compare", 0, "--QAinput", "Compare QA histograms", "--qa", "--QAinputHistogramsOnly")
AddHelp("help", 'h')
EndConfig()
Expand Down
69 changes: 38 additions & 31 deletions GPU/GPUTracking/qa/GPUQA.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,17 +144,11 @@ static const GPUSettingsQA& GPUQA_GetConfig(GPUChainTracking* chain)
}
}

// static const constexpr bool PLOT_ROOT = 0;
// static const constexpr bool FIX_SCALES = 0;
static const constexpr bool PERF_FIGURE = 0;
// static const constexpr float FIXED_SCALES_MIN[5] = {-0.05, -0.05, -0.2, -0.2, -0.5};
// static const constexpr float FIXED_SCALES_MAX[5] = {0.4, 0.7, 5, 3, 6.5};
static const constexpr float LOG_PT_MIN = -1.;

static constexpr float Y_MAX = 40;
static constexpr float Z_MAX = 100;
static constexpr float PT_MIN = GPUCA_MIN_TRACK_PTB5_DEFAULT;
// static constexpr float PT_MIN2 = 0.1;
static constexpr float PT_MIN_PRIM = 0.1;
static constexpr float PT_MIN_CLUST = GPUCA_MIN_TRACK_PTB5_DEFAULT;
static constexpr float PT_MAX = 20;
Expand Down Expand Up @@ -375,10 +369,10 @@ void GPUQA::SetAxisSize(T* e)
e->GetXaxis()->SetLabelSize(0.045);
}

void GPUQA::SetLegend(TLegend* l)
void GPUQA::SetLegend(TLegend* l, bool bigText)
{
l->SetTextFont(72);
l->SetTextSize(0.016);
l->SetTextSize(bigText ? 0.03 : 0.016);
l->SetFillColor(0);
}

Expand Down Expand Up @@ -419,15 +413,20 @@ void GPUQA::DrawHisto(TH1* histo, char* filename, char* options)

void GPUQA::doPerfFigure(float x, float y, float size)
{
if (!PERF_FIGURE) {
const char* str_perf_figure_1 = "ALICE Performance";
const char* str_perf_figure_2_mc = "MC, Pb#minusPb, #sqrt{s_{NN}} = 5.36 TeV";
const char* str_perf_figure_2_data = "Pb#minusPb, #sqrt{s_{NN}} = 5.36 TeV";

if (mConfig.perfFigure == 0) {
return;
}
TLatex* t = createGarbageCollected<TLatex>();
TLatex* t = createGarbageCollected<TLatex>(); // TODO: We could perhaps put everything in a legend, to get a white background if there is a grid
t->SetNDC(kTRUE);
t->SetTextColor(1);
t->SetTextSize(size);
t->DrawLatex(x, y, str_perf_figure_1);
t->DrawLatex(x, y - 0.01 - size, str_perf_figure_2);
t->SetTextSize(size * 0.8);
t->DrawLatex(x, y - 0.01 - size, mConfig.perfFigure > 0 ? str_perf_figure_2_mc : str_perf_figure_2_data);
}

void GPUQA::SetMCTrackRange(int32_t min, int32_t max)
Expand Down Expand Up @@ -1954,20 +1953,22 @@ void GPUQA::RunQA(bool matchOnly, const std::vector<o2::tpc::TrackTPC>* tracksEx
mTrackingScratchBuffer.shrink_to_fit();
}

void GPUQA::GetName(char* fname, int32_t k)
void GPUQA::GetName(char* fname, int32_t k, bool noDash)
{
const int32_t nNewInput = mConfig.inputHistogramsOnly ? 0 : 1;
if (k || mConfig.inputHistogramsOnly || mConfig.name.size()) {
if (!(mConfig.inputHistogramsOnly || k)) {
snprintf(fname, 1024, "%s - ", mConfig.name.c_str());
snprintf(fname, 1024, "%s%s", mConfig.name.c_str(), noDash ? "" : " - ");
} else if (mConfig.compareInputNames.size() > (unsigned)(k - nNewInput)) {
snprintf(fname, 1024, "%s - ", mConfig.compareInputNames[k - nNewInput].c_str());
snprintf(fname, 1024, "%s%s", mConfig.compareInputNames[k - nNewInput].c_str(), noDash ? "" : " - ");
} else {
strcpy(fname, mConfig.compareInputs[k - nNewInput].c_str());
if (strlen(fname) > 5 && strcmp(fname + strlen(fname) - 5, ".root") == 0) {
fname[strlen(fname) - 5] = 0;
}
strcat(fname, " - ");
if (!noDash) {
strcat(fname, " - ");
}
}
} else {
fname[0] = 0;
Expand Down Expand Up @@ -2187,8 +2188,8 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
mCTracks->cd();
mPTracks = createGarbageCollected<TPad>("p0", "", 0.0, 0.0, 1.0, 1.0);
mPTracks->Draw();
mLTracks = createGarbageCollected<TLegend>(0.9 - legendSpacingString * 1.45, 0.93 - (0.93 - 0.86) / 2. * (float)ConfigNumInputs, 0.98, 0.949);
SetLegend(mLTracks);
mLTracks = createGarbageCollected<TLegend>(0.9 - legendSpacingString * 1.5, 0.93 - (0.93 - 0.86) / 2. * (float)ConfigNumInputs, 0.98, 0.949);
SetLegend(mLTracks, true);

for (int32_t i = 0; i < 2; i++) {
snprintf(name, 2048, "ctrackst0%d", i);
Expand All @@ -2204,8 +2205,8 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
mCNCl[i]->cd();
mPNCl[i] = createGarbageCollected<TPad>("p0", "", 0.0, 0.0, 1.0, 1.0);
mPNCl[i]->Draw();
mLNCl[i] = createGarbageCollected<TLegend>(0.9 - legendSpacingString * 1.45, 0.93 - (0.93 - 0.86) / 2. * (float)ConfigNumInputs, 0.98, 0.949);
SetLegend(mLNCl[i]);
mLNCl[i] = createGarbageCollected<TLegend>(0.9 - legendSpacingString * 1.45, 0.93 - (0.93 - 0.86) / 2. * (float)ConfigNumInputs, 0.98, 0.949); // TODO: Fix sizing of legend, and also fix font size
SetLegend(mLNCl[i], true);
}

mCClXY = createGarbageCollected<TCanvas>("clxy", "Number of clusters per X / Y", 0, 0, 700, 700. * 2. / 3.);
Expand Down Expand Up @@ -2288,7 +2289,7 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
continue;
}
e->SetMarkerColor(kBlack);
e->SetLineColor(colorNums[(k * 3 + l) % COLORCOUNT]);
e->SetLineColor(colorNums[(k < 3 ? (l * 3 + k) : (k * 3 + l)) % COLORCOUNT]);
e->GetHistogram()->GetYaxis()->SetRangeUser(-0.02, 1.02);
e->Draw(k || l ? "same P" : "AP");
if (j == 0) {
Expand Down Expand Up @@ -2776,7 +2777,7 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
if (!mConfig.enableLocalOutput) {
continue;
}
doPerfFigure(i != 2 ? 0.37 : 0.6, 0.295, 0.030);
doPerfFigure(i == 0 ? 0.37 : (i == 1 ? 0.34 : 0.6), 0.295, 0.030);
mCClust[i]->cd();
mCClust[i]->Print(i == 2 ? "plots/clusters_integral.pdf" : i == 1 ? "plots/clusters_relative.pdf" : "plots/clusters.pdf");
if (mConfig.writeRootFiles) {
Expand Down Expand Up @@ -2827,19 +2828,21 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
e->SetMinimum(tmpMax * -0.02);
e->SetStats(kFALSE);
e->SetLineWidth(1);
e->GetYaxis()->SetTitle("a.u.");
e->GetXaxis()->SetTitle("#it{p}_{Tmc} (GeV/#it{c})");
e->SetTitle("Number of Tracks vs #it{p}_{T}");
e->GetYaxis()->SetTitle("Number of Tracks");
e->GetXaxis()->SetTitle("#it{p}_{T} (GeV/#it{c})");
if (qcout) {
qcout->Add(e);
}
e->SetMarkerColor(kBlack);
e->SetLineColor(colorNums[k % COLORCOUNT]);
e->Draw(k == 0 ? "" : "same");
GetName(fname, k);
snprintf(name, 2048, "%sTrack Pt", fname);
GetName(fname, k, mConfig.inputHistogramsOnly);
snprintf(name, 2048, mConfig.inputHistogramsOnly ? "%s" : "%sTrack #it{p}_{T}", fname);
mLTracks->AddEntry(e, name, "l");
}
mLTracks->Draw();
doPerfFigure(0.63, 0.7, 0.030);
mCTracks->cd();
mCTracks->Print("plots/tracks.pdf");
if (mConfig.writeRootFiles) {
Expand Down Expand Up @@ -2871,19 +2874,21 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
e->SetMinimum(tmpMax * -0.02);
e->SetStats(kFALSE);
e->SetLineWidth(1);
e->SetTitle(i ? "Track t_{0} resolution" : "Track t_{0} distribution");
e->GetYaxis()->SetTitle("a.u.");
e->GetXaxis()->SetTitle(i ? "to vs t0_{mc}" : "t0");
e->GetXaxis()->SetTitle(i ? "t_{0} - t_{0, mc}" : "t_{0}");
if (qcout) {
qcout->Add(e);
}
e->SetMarkerColor(kBlack);
e->SetLineColor(colorNums[k % COLORCOUNT]);
e->Draw(k == 0 ? "" : "same");
GetName(fname, k);
snprintf(name, 2048, "%sTrack T0 %s", fname, i ? "" : "resolution");
GetName(fname, k, mConfig.inputHistogramsOnly);
snprintf(name, 2048, mConfig.inputHistogramsOnly ? "%s (%s)" : "%sTrack t_{0} %s", fname, i ? "" : "resolution");
mLT0[i]->AddEntry(e, name, "l");
}
mLT0[i]->Draw();
doPerfFigure(0.63, 0.7, 0.030);
mCT0[i]->cd();
snprintf(name, 2048, "plots/t0%s.pdf", i ? "_res" : "");
mCT0[i]->Print(name);
Expand Down Expand Up @@ -2916,19 +2921,21 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
e->SetMinimum(tmpMax * -0.02);
e->SetStats(kFALSE);
e->SetLineWidth(1);
e->SetTitle(i ? "Number of Rows with attached Cluster" : "Number of Clusters");
e->GetYaxis()->SetTitle("a.u.");
e->GetXaxis()->SetTitle("NClusters");
e->GetXaxis()->SetTitle(i ? "N_{Rows with Clusters}" : "N_{Clusters}");
if (qcout) {
qcout->Add(e);
}
e->SetMarkerColor(kBlack);
e->SetLineColor(colorNums[k % COLORCOUNT]);
e->Draw(k == 0 ? "" : "same");
GetName(fname, k);
snprintf(name, 2048, "%sNClusters%d", fname, i);
GetName(fname, k, mConfig.inputHistogramsOnly);
snprintf(name, 2048, mConfig.inputHistogramsOnly ? "%s" : (i ? "%sN_{Clusters}" : "%sN_{Rows with Clusters}"), fname);
mLNCl[i]->AddEntry(e, name, "l");
}
mLNCl[i]->Draw();
doPerfFigure(0.6, 0.7, 0.030);
mCNCl[i]->cd();
snprintf(name, 2048, "plots/nClusters%s.pdf", i ? "_corrected" : "");
mCNCl[i]->Print(name);
Expand Down
7 changes: 2 additions & 5 deletions GPU/GPUTracking/qa/GPUQA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,12 @@ class GPUQA
void CopyO2MCtoIOPtr(GPUTrackingInOutPointers* ptr);
template <class T>
void SetAxisSize(T* e);
void SetLegend(TLegend* l);
void SetLegend(TLegend* l, bool bigText = false);
double* CreateLogAxis(int32_t nbins, float xmin, float xmax);
void ChangePadTitleSize(TPad* p, float size);
void DrawHisto(TH1* histo, char* filename, char* options);
void doPerfFigure(float x, float y, float size);
void GetName(char* fname, int32_t k);
void GetName(char* fname, int32_t k, bool noDash = false);
template <class T>
T* GetHist(T*& ee, std::vector<std::unique_ptr<TFile>>& tin, int32_t k, int32_t nNewInput);

Expand Down Expand Up @@ -234,9 +234,6 @@ class GPUQA
const GPUSettingsQA& mConfig;
const GPUParam* mParam;

const char* str_perf_figure_1 = "ALICE Performance 2018/03/20";
// const char* str_perf_figure_2 = "2015, MC pp, #sqrt{s} = 5.02 TeV";
const char* str_perf_figure_2 = "2015, MC Pb-Pb, #sqrt{s_{NN}} = 5.02 TeV";
//-------------------------

std::vector<mcLabelI_t> mTrackMCLabels;
Expand Down