Skip to content

Fix Cloning App from Gitlab #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dvvanessastoiber wants to merge 3 commits into from
Closed

Fix Cloning App from Gitlab #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
807241e
change repo url
dvvanessastoiber Nov 15, 2024
27e346b
switch branches
dvvanessastoiber Nov 15, 2024
b1e29c2
fix lint
dvvanessastoiber Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-node-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ env:
PYPI_REGISTRY: "https://upload.pypi.org/legacy/"
PYPI_USERNAME: "datavisyn"
PYTHON_VERSION: "3.10"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"
POSTGRES_HOSTNAME: postgres_${{ github.job }}_${{ inputs.deduplication_id }}_${{ github.run_id }}_${{ github.run_attempt }}

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:
env:
NPM_REGISTRY: "https://registry.npmjs.org/"
NODE_VERSION: "20.9"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"

permissions:
contents: read
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-product.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ env:
TIME_ZONE: "Europe/Vienna"
NODE_VERSION: "20.9"
PYTHON_VERSION: "3.10"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"
PYTHON_BASE_IMAGE: "python:3.10.8-slim-bullseye"
DATAVISYN_PYTHON_BASE_IMAGE: "188237246440.dkr.ecr.eu-central-1.amazonaws.com/datavisyn/base/python:main"
DATAVISYN_NGINX_BASE_IMAGE: "188237246440.dkr.ecr.eu-central-1.amazonaws.com/datavisyn/base/nginx:main"
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
fail-fast: true
matrix:
component: ${{fromJson(needs.prepare-build.outputs.components)}}
uses: datavisyn/github-workflows/.github/workflows/build-single-product-part.yml@main
uses: datavisyn/github-workflows/.github/workflows/build-single-product-part.yml@vstoiber-gitlab
with:
component: ${{ matrix.component }}
image_tag1: ${{ needs.prepare-build.outputs.image_tag1 }}
Expand All @@ -105,7 +105,7 @@ jobs:
fail-fast: true
matrix:
component: ${{fromJson(needs.prepare-build.outputs.components)}}
uses: datavisyn/github-workflows/.github/workflows/build-workspace-product-part.yml@main
uses: datavisyn/github-workflows/.github/workflows/build-workspace-product-part.yml@vstoiber-gitlab
with:
component: ${{ matrix.component }}
image_tag1: ${{ needs.prepare-build.outputs.image_tag1 }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-push-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ permissions:
contents: read

env:
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-push-helm-chart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ permissions:
contents: read

env:
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"

concurrency:
group: '${{ github.workflow }}-${{ github.ref || github.head_ref }}'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
PYPI_REGISTRY: "https://upload.pypi.org/legacy/"
PYPI_USERNAME: "test"
PYTHON_VERSION: "3.10"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"

permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-single-product-part.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ env:
TIME_ZONE: "Europe/Vienna"
NODE_VERSION: "20.9"
PYTHON_VERSION: "3.10"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"
PYTHON_BASE_IMAGE: "python:3.10.8-slim-bullseye"
DATAVISYN_PYTHON_BASE_IMAGE: "188237246440.dkr.ecr.eu-central-1.amazonaws.com/datavisyn/base/python:main"
DATAVISYN_NGINX_BASE_IMAGE: "188237246440.dkr.ecr.eu-central-1.amazonaws.com/datavisyn/base/nginx:main"
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
cd "./tmp/$COMPONENT"
repository="$REPO"
if [[ $repository == *"gitlab"* && -n $GITLAB_TOKEN ]] ; then
repository=${repository/"https://"/"https://$GITLAB_TOKEN@"}
repository=https://$GITLAB_TOKEN@${repository}
Copy link
Contributor

@puehringer puehringer Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change really necessary if we prefix the repo in visyn_product with https://?

Copy link
Contributor Author

@dvvanessastoiber dvvanessastoiber Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, thank you! 👍

else
repository=https://$GH_TOKEN@github.com/${repository}.git
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-workspace-product-part.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ env:
TIME_ZONE: "Europe/Vienna"
NODE_VERSION: "20.9"
PYTHON_VERSION: "3.10"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"
PYTHON_BASE_IMAGE: "python:3.10.8-slim-bullseye"
DATAVISYN_PYTHON_BASE_IMAGE: "188237246440.dkr.ecr.eu-central-1.amazonaws.com/datavisyn/base/python:main"
DATAVISYN_NGINX_BASE_IMAGE: "188237246440.dkr.ecr.eu-central-1.amazonaws.com/datavisyn/base/nginx:main"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-helm-chart-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ permissions:
contents: read

env:
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"

jobs:
check-helm-chart-version:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-product.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ concurrency:

env:
GA_VERSION: "main"
WORKFLOW_BRANCH: "main"
WORKFLOW_BRANCH: "vstoiber-gitlab"

jobs:
deploy:
Expand Down