docs: update dip-0023 - removed mentions of non existing min_activation_height

[knst]

see changes.

This PR replaces https://github.com/dashpay/dips/pull/146/files

Summary by CodeRabbit

• Documentation
  • Updated the status of DIP 23 to "Final" in the summary table.
  • Clarified activation stages in DIP 23, simplifying explanations and emphasizing miner signalling's role in the activation process. Removed detailed formulas and fixed waiting periods.
  • Added special thanks to Konstantin Akimov in DIP 23 metadata.

[thephez]

I'm waiting for @PastaPastaPasta to comment. Perhaps it should be discussed on a Core call?

[PastaPastaPasta]

generally LGTM; @thephez please review language

[thephez]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The status of DIP 23 was updated to "Final" in the proposal summary table. The DIP 23 document was revised to clarify Stage 0 and Stage 2 activation descriptions by removing specific formulas and parameters, emphasizing that miner signalling solely determines activation progression after the initial cycle.

Changes

File(s)	Change Summary
README.md	Updated DIP 23 status from "Proposed" to "Final" in the summary table.
dip-0023.md	Clarified Stage 0 and Stage 2 descriptions; removed formulas and parameters related to activation heights; simplified activation explanation to focus on miner signalling.

Estimated code review effort

2 (10–30 minutes)

Poem

A hop from "Proposed" to "Final"—what a leap!
Activation now simpler, no formulas to keep.
Miners decide, the process is clear,
No more waiting windows, the path is near.
DIP 23, you’re ready—let’s cheer!
🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07c449b and 6f8d28b.

📒 Files selected for processing (1)

• dip-0023.md (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• dip-0023.md

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

dip-0023.md (2)

50-54: Clarify wording in Stage 0

“Impossible to move from defined” is slightly ambiguous. Consider rephrasing to “The deployment state remains defined; no transition is possible during Stage 0.” – this preserves the intent while improving readability.

---

87-89: Minor grammar tweak

“Once a new cycle started…” → “Once a new cycle starts…”.
Small polish that avoids tense mismatch.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a618e19 and 0246fd6.

📒 Files selected for processing (2)

• README.md (1 hunks)
• dip-0023.md (2 hunks)

🔇 Additional comments (1)

dip-0023.md (1)

78-81: Variable naming still implies implicit calculation – double-check intent

You removed min_activation_height, yet keep a formula that sets masternode_activation_height based on the block where mnhfsignal is mined. That’s fine, but ensure older references to min_activation_height were purged elsewhere in the doc and in implementation notes so no stale parameter survives.

[thephez]

A few rewording suggestions. We should also update the status in the DIP as indicated by the coderabbit comment.