[coverage] Support workspaces in coverage filters #2574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
natebosch
reviewed
Dec 10, 2025
| final pubspec = Pubspec.parse(yaml, sourceUrl: pubspecUri); | ||
| results.add(pubspec.name); | ||
| for (final workspace in pubspec.workspace ?? <String>[]) { | ||
| _getAllWorkspaceNames(packageRoot.resolve('$workspace/'), results); |
Member
There was a problem hiding this comment.
Why does this need to be recursive? Each package in a workspace should only contribute one package to the set...
Contributor
Author
There was a problem hiding this comment.
Workspaces can contain workspaces, and can form a tree. I asked the pub folks about this edge case when I was building this feature for package:coverage, and they said it's an intended (though uncommon) use case.
Co-authored-by: Nate Bosch <nbosch@google.com>
natebosch
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/tools#2269
The bug is that when
dart test --coverage...is run in a package that's part of a workspace, the default coverage filter is set to the name of the workspace, rather than the package under test. Inpackage:coverageI solved this by searching for all the nested packages, and using those as the default filter. Another approach would be to restrict the default filter to only include the package under test, but I think users are more likely to want all the workspace's packages included in the report.This change introduces a dependency on
package:pubspec_parse. Hopefully that's ok.